Add fully functional Ruby client compatible with Go client - #70
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
brandur
force-pushed
the
brandur-full-implementation
branch
from
September 24, 2026 08:15
ab651bb to
27be74b
Compare
brandur
force-pushed
the
brandur-full-implementation
branch
6 times, most recently
from
September 28, 2026 19:28
0514783 to
55917e6
Compare
brandur
force-pushed
the
brandur-full-implementation
branch
7 times, most recently
from
September 30, 2026 23:05
1cf1fd1 to
4284fd2
Compare
Contributor
Author
|
@codex review |
1 similar comment
Contributor
Author
|
@codex review |
brandur
force-pushed
the
brandur-full-implementation
branch
2 times, most recently
from
October 1, 2026 17:09
92d658b to
dd3589c
Compare
Here, try to do a full port of River to Ruby using a similar technique to Rust through repeated refinement iterations. I also had it try to go through each of River's features sections in the docs and make sure we have equivalent Ruby functionality. I changed a fair bit through manual inspection of the resulting APIs, but there's still a reasonable possibility we'll notice more things and want to make a few additional tweaks before fully committing. I also have a full Pro implementation locally, but have left it out of this change set. We'd ship this from a private gem server separately.
brandur
force-pushed
the
brandur-full-implementation
branch
from
October 1, 2026 19:27
dd3589c to
aaad360
Compare
Contributor
Author
|
@bgentry Gonna get a start on merging this one and possibly do a release. I've had Codex try another couple review and simplification passes here, pulled in all upstream changes, and verified no serious backward incompatibilities. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, try to do a full port of River to Ruby using a similar technique
to Rust through repeated refinement iterations.
I also had it try to go through each of River's features sections in the
docs and make sure we have equivalent Ruby functionality.
I changed a fair bit through manual inspection of the resulting APIs,
but there's still a reasonable possibility we'll notice more things and
want to make a few additional tweaks before fully committing.
I also have a full Pro implementation locally, but have left it out of
this change set. We'd ship this from a private gem server separately.