Repository navigation
Conversation
brandur
force-pushed
the
brandur-job-complete-tx
branch
2 times, most recently
from
October 10, 2026 04:03
521db84 to
b4e1751
Compare
An omission on the Ruby implementation is that a transactional completion path never made it in. Here, correct the oversight by adding `#job_complete_tx`. The naming is close to Rust's `job_complete_tx` and TypeScript's `completeTx`.
brandur
force-pushed
the
brandur-job-complete-tx
branch
from
October 10, 2026 05:07
b4e1751 to
792a22a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An omission on the Ruby implementation is that a transactional
completion path never made it in.
Here, correct the oversight by adding
#job_complete_tx. The naming isclose to Rust's
job_complete_txand TypeScript'scompleteTx.