Add configuration LeaderElectionDisabled - #1382
Merged
Merged
Conversation
brandur
force-pushed
the
brandur-leader-election-disabled
branch
from
September 24, 2026 21:01
34390d6 to
7ef9f48
Compare
Adds client configuration option `LeaderElectionDisabled`, allowing a caller to explicitly prevent the client from participating in leader election, also preventing it from running any maintenance services. This option is being added a user's request, and is aimed at a specific situation where they have specialized boxes that work only specific job kinds, and these boxes should ideally not be working on anything else. At least one client will have to omit this option or no maintenance services will run.
brandur
force-pushed
the
brandur-leader-election-disabled
branch
from
September 24, 2026 21:02
7ef9f48 to
21f990a
Compare
Contributor
Author
|
@bgentry See email. Any FUD on this one? |
bgentry
approved these changes
Sep 25, 2026
bgentry
left a comment
bgentry
left a comment
Contributor
There was a problem hiding this comment.
Yeah I know we've talked about this before, seems overdue to just introduce the knob for some use cases. Do you think it warrants doc site additions on the leader election page?
Contributor
Author
Hm, I'll take a look, but it might be an usual enough situation that there doesn't have to be a dedicated docs section. People/robots I'm sure will also check the Godoc and it'll be well documented there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds client configuration option
LeaderElectionDisabled, allowing acaller to explicitly prevent the client from participating in leader
election, also preventing it from running any maintenance services.
This option is being added a user's request, and is aimed at a specific
situation where they have specialized boxes that work only specific job
kinds, and these boxes should ideally not be working on anything else.
At least one client will have to omit this option or no maintenance
services will run.