fix(compatibility): add missing torch 2.3.1 to Python matrix, add reg…#988
fix(compatibility): add missing torch 2.3.1 to Python matrix, add reg…#988tejask011 wants to merge 1 commit into
Conversation
|
@tejask011 is attempting to deploy a commit to the rishabhmishra0510-5147's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR adds the missing PyTorch 2.3.1 entry to the Python compatibility matrix, documenting its supported Python and CUDA versions, and introduces three regression tests to verify the resolver now correctly validates compatibility checks for this version instead of silently bypassing them. ChangesPyTorch 2.3.1 Compatibility Fix
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🔍 PR Action RequiredHi @tejask011, We detected some items on this Pull Request that require attention: ❌ Failing CI ChecksThe following check runs or commit statuses are failing (ignoring vercel): Please resolve the issues above to proceed. Last updated: Thu, 11 Jun 2026 05:21:19 GMT |
Both failing CI checks (Frontend Build & Lint and Backend Tests) are pre-existing failures on the main branch unrelated to this PR. |
Description
This PR fixes a compatibility matrix inconsistency where
torch==2.3.1was present in the CUDA compatibility matrix but missing from the Python compatibility matrix.Because of the missing entry, the Compatibility Resolver treated
torch 2.3.1as an unknown version and skipped Python and CUDA compatibility validation. This allowed unsupported combinations to pass validation and generate invalid installation scripts.The fix adds the missing
FrameworkVersionEntryfortorch 2.3.1with the correct Python and CUDA support metadata. Additionally, regression tests have been added to ensure unsupported Python and CUDA versions are properly rejected and valid configurations continue to resolve successfully.Related Issues
Fixes #987
Changes Made
torch 2.3.1entry tobackend/app/compatibility/matrix/python.pytorch 2.3.1configurations resolve correctlytorch 2.3.1Verification
pytest tests/successfullySafetyFilterDocumentation
docs/FEATURES.md(if adding a feature/profile)CHANGELOG.mdScreenshots (if applicable)
N/A – Backend-only change with no UI modifications.
Summary by CodeRabbit
New Features
Tests