feat: journal#513
Draft
duyquang6 wants to merge 15 commits into
Draft
Conversation
Contributor
Author
|
benchmark |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a custom, flattened Journal implementation for PEVM in crates/pevm/src/journal.rs to replace REVM's default journal wrapping. The EVM setup and type definitions in both the Ethereum and Rise chain modules have been updated to utilize this new custom journal. The review feedback suggests a minor improvement in crates/pevm/src/journal.rs to use the more idiomatic into_word() method on Address instead of slicing and calling B256::left_padding_from when constructing log topics.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Comment on lines
+142
to
+146
| let topics = vec![ | ||
| ETH_TRANSFER_LOG_TOPIC, | ||
| B256::left_padding_from(from.as_slice()), | ||
| B256::left_padding_from(to.as_slice()), | ||
| ]; |
There was a problem hiding this comment.
In alloy_primitives, Address (which is FixedBytes<20>) has a built-in into_word() method that converts it to a B256 with left zero-padding. Using into_word() is more idiomatic and cleaner than slicing and calling B256::left_padding_from.
Suggested change
| let topics = vec![ | |
| ETH_TRANSFER_LOG_TOPIC, | |
| B256::left_padding_from(from.as_slice()), | |
| B256::left_padding_from(to.as_slice()), | |
| ]; | |
| let topics = vec![ | |
| ETH_TRANSFER_LOG_TOPIC, | |
| from.into_word(), | |
| to.into_word(), | |
| ]; |
| return; | ||
| } | ||
|
|
||
| let topics = vec![BURN_LOG_TOPIC, B256::left_padding_from(address.as_slice())]; |
There was a problem hiding this comment.
Similarly, we can use address.into_word() here to convert the Address to a B256 topic with left zero-padding.
Suggested change
| let topics = vec![BURN_LOG_TOPIC, B256::left_padding_from(address.as_slice())]; | |
| let topics = vec![BURN_LOG_TOPIC, address.into_word()]; |
|
✅ Gigagas benchmark for commit f622d71 Detail |
|
✅ Mainnet benchmark for commit f622d71 This pr: Detail |
Contributor
Author
|
benchmark |
1 similar comment
Contributor
Author
|
benchmark |
|
✅ Gigagas benchmark for commit cb269de Detail |
|
✅ Mainnet benchmark for commit cb269de This pr: Detail |
|
✅ Gigagas benchmark for commit 5dac600 Detail |
Contributor
Author
|
benchmark |
|
✅ Mainnet benchmark for commit 5dac600 This pr: Detail |
|
✅ Gigagas benchmark for commit 0f8052a Detail |
|
✅ Mainnet benchmark for commit 0f8052a This pr: Detail |
Contributor
Author
|
benchmark |
|
✅ Gigagas benchmark for commit d52bd51 Detail |
|
✅ Mainnet benchmark for commit d52bd51 This pr: Detail |
Contributor
Author
|
benchmark |
|
✅ Gigagas benchmark for commit 04eed56 Detail |
|
✅ Mainnet benchmark for commit 04eed56 This pr: Detail |
Contributor
Author
|
benchmark |
|
✅ Gigagas benchmark for commit 371f6ae Detail |
|
✅ Mainnet benchmark for commit 371f6ae This pr: Detail |
Contributor
Author
|
benchmark |
Contributor
Author
|
benchmark |
|
✅ Gigagas benchmark for commit 3313682 Detail |
|
✅ Mainnet benchmark for commit 3313682 This pr: Detail |
|
✅ Gigagas benchmark for commit d52bd51 Detail |
|
✅ Mainnet benchmark for commit d52bd51 This pr: Detail |
nuke dead code
transaction_id was designed for transact_many — cross-tx account warmth via integer comparison. We always call transact() (transact_one + finalize), so state is empty at the start of every tx. The transaction_id != current check was always false; only the Cold status bit (set by sub-call checkpoint reverts) ever mattered. Replace is_cold_transaction_id with direct Cold bit checks. Simplify discard_tx to skip journal replay — finalize() takes and discards state immediately after on failed txs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nuke dead code