Modified Call Log Details structure with Activity Logging#41
Open
SushilMallRC wants to merge 19 commits into
Open
Modified Call Log Details structure with Activity Logging#41SushilMallRC wants to merge 19 commits into
SushilMallRC wants to merge 19 commits into
Conversation
SushilMallRC
force-pushed
the
RCLABS-1189-ActivityLogging
branch
from
9a1af96 to
9e78df9
Compare
DaKingKong
requested changes
Aug 5, 2025
Contributor
DaKingKong
left a comment
DaKingKong
left a comment
There was a problem hiding this comment.
Some changes required. Most importantly, we want to store multi select as multi select, not as different booleans.
| function shouldAutoLogCall(call, userSettings) { | ||
| let shouldAutoLog = false; | ||
|
|
||
| if (call.direction === 'Inbound') { |
Contributor
There was a problem hiding this comment.
This if else bit should be formatted so to be more readable
| function shouldAutoLogCallFromPresence(call, userSettings) { | ||
| let shouldAutoLog = false; | ||
|
|
||
| if (call.direction === 'Inbound') { |
Contributor
There was a problem hiding this comment.
This if else bit should be formatted so to be more readable
DaKingKong
requested changes
Aug 6, 2025
| ]; | ||
| return activityLoggingValues; | ||
| })(), | ||
| readOnly: userCore.getAutoLogAnsweredIncomingSetting(userSettings, isAdmin).readOnly || |
Contributor
There was a problem hiding this comment.
Need one more interface here: userCore.getActivityLoggingSetting()
This whole section is still clunky.
The new interface will be aligned with how admin setting is setup as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ChangeLog
✨ New Features