This repository was archived by the owner on Oct 7, 2019. It is now read-only.
Implement unitary QVM expectation#21
Closed
ftripier wants to merge 1 commit into
Closed
Conversation
* also, pin pyquil to compatible version
Author
|
Oh, is this being deprecated in favor of rigetti/pyquil#552? I feel goofy. |
Contributor
|
sorry for not communicating this more broadly! Was waiting for rigetti/pyquil#552 to get merged before adding a note here. The linked pr has code for doing expectation. I would legitimately appreciate it if you gave it a review to make sure I did it correctly :) |
Author
|
Ha! It is I who need to review your code to make sure this was correct! Looks much more efficient than mine. Well done! I'll close. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I changed the reference QVM's version of pyquil to one that works with all the code - I struggled a lot trying to use it initially until I did a fair bit of git archaeology to find a pyquil version that would work with the imports.