Repository navigation
Accepts the 0.10.0 Amendments - #159
Merged
Merged
Conversation
Flips ADR-0003's whole-delivery wrapper Amendment and ADR-0002's outbound BasicHTTP send Amendment to accepted. Both shipped in statifier_router 0.10.0; every claim was re-verified by anchor at the v0.10.0 tag, and a dated foot Note on each record says what was checked. Only the two status lines change in place. Docs only: no quality gate applies (no gated path touched). Refs: sr-4llw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips two Amendments whose code shipped in statifier_router 0.10.0 (tag
v0.10.0, atf823adb, published on Hex 2026-10-02T11:42:49Z) from proposed to accepted. Each status word changes in place, and each record gets a dated Note at its foot recording the flip and what was checked.git diff origin/main -- docs/adr/removes no line other than the twoStatus: proposedlines.ADR-0003, the Amendment of 2026-10-02 on the whole-delivery wrapper. Version 0.10.0; verified at
f823adb(the tag andmain). Code from PR 152 and its cure. Claims checked by anchor: the option's shape check inStatifierRouter.Config.new/1(privatehooks/2) and its refusal tuple; the contract in the package-internalConfig.around_delivery/4(work runs once, its answer is returned, anything else raisesArgumentError, a failing wrapper is re-raised); the absent key runs the work directly; the:routedoor inStatifierRouter.route/3, the:partitiondoor in the privatebindings_for/2ofStatifierRouter.Broadway, and the:basichttpdoor in the privatedeliver/5ofStatifierRouter.BasicHTTP.Frontwith the token resolved outside;StatifierRouter.DeliveryandStatifierRouter.SendHandlernever call the wrapper; the commit-together note inConfig's docs and the README; the tests intest/statifier_router/around_delivery_test.exs. The Amendment's open point (wrapping the execution target where no wrapper reaches it) is still stated as undecided, and the code still leaves it unwrapped.ADR-0002, the Amendment of 2026-10-02 on the outbound BasicHTTP send. Version 0.10.0; verified at
f823adb. Statifier cites checked at itsv2.10.0tag and statifier_persistence at 0.18.0, the versionsmix.lockresolves. This Amendment changes no code; its recipe and test landed in PR 147. Claims checked by anchor: the processor delegation inStatifierRouter.BasicHTTP.deliver/3andperform/2;Statifier.Send.BasicHTTP's planned instructions, failure report,scxml-send-keyfields and delayed-send timer; the executor re-entry inStatifierPersistence.Executions;Addresses.by_execution/2; the answers ofDelivery.deliver_event/4under acreate: :neverplan (delivered, duplicate, dropped finished, dropped no_execution, and nounmatched_eventoff the binding path);deliver_event/4sets no delivery scope; the README recipe sections; the failure-path tests intest/statifier_router/basic_http_send_test.exs. Three later changes touch files it cites (PR 149, PR 151, PR 152), and none of them changes a claim. The delayed send is still open, as the Amendment says. The Notes of 2026-10-02 after the Amendment carry no status and do not flip.Not flipped. ADR-0001's Amendment of 2026-10-02 stays proposed: its code ships in a later version.
Docs only: this branch touches no gated path, so there is no local gate to run; CI runs the full quality gate.