Accepts the two Amendments shipped in 0.24.0 - #253
Merged
Merged
Conversation
Both 2026-09-29 Amendments shipped in statifier_persistence 0.24.0 (tag v0.24.0 at 9f9eaa0). Flips each Amendment's status word from proposed to accepted in place, and adds a dated foot Note to each record naming what was re-read at 20e59b2, which is main. ADR-0012's Note also names the two earlier sentences that still call the conformance suite's nested module RetiringSerialization, and cites the reserved-prefix change (20fb8bb) that renamed it ConformanceRetiringSerialization. It decides nothing new. Only the two status lines are removed under docs/adr/. The branch touches no gated path (lib/, test/, config/, mix.exs, mix.lock), so no gate applies; CI runs it on the request. Refs: sp-lbxd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accepts two Amendments whose code shipped in statifier_persistence 0.24.0 (tag
v0.24.0at9f9eaa0), and adds a dated foot Note to each record. The flips are the conductor's, under the operator's standing campaign consent to flip a record whose code has shipped in a published version.Records
ADR-0012, "the per-hash lock is keyed by the store, never by the tenant" (2026-09-29). Version 0.24.0; every claim checked at
20e59b2(main; the one commit since the tag adds a Note to ADR-0012 and changes nothing inlib/ortest/). Checked:chart_lock/3hasheschart_store/1's answer, a space and the content hash under@chart_lock_namespace, on Postgres only;chart_store/1quotes__schema__(:source)and, when present,__schema__(:prefix), joined by a dot;supports_chart_retirement?/1reads the same two values;fetch_retired_info/2takes the lock shared andretire_chart/3exclusive (lib/statifier_persistence/storage/ecto.ex); the charts unique index is oncontent_hashalone (lib/statifier_persistence/ecto/migrations/v01.ex,up/1) and no later migration changes it; the two named cases exist intest/statifier_persistence/ecto/retire_chart_race_test.exsover the hosts the Amendment names; the 0.24.0 changelog carries the Changed line.ADR-0003, "every name the conformance suite defines in a host module carries one reserved prefix" (2026-09-29). Version 0.24.0; every claim checked at
20e59b2. Checked: every attribute and function theusingblock oflib/statifier_persistence/testing/storage_conformance.exdefines in the host module starts withconformance_, its nested modules withConformance, and the one public function isconformance_forward_adapter_call/4; the moduledoc states the prefix contract, the generated test names and the six aliases with the two ways around them;test/statifier_persistence/storage/reserved_prefix_conformance_test.exsandtest/statifier_persistence/storage/setup_ordering_conformance_test.exshold what the Amendment says; the generated test names are the same set before and after the change, and the assertion lines differ only by the prefix; the 0.24.0 changelog carries the Changed line.The retiring module's name. ADR-0012's accepted 2026-09-28 Amendment ("Pinned by.") and its 2026-09-29 Note ("The cases.") name the suite's nested module
RetiringSerialization. The reserved-prefix change (20fb8bb) renamed itConformanceRetiringSerialization, which is where it is defined onmain. The ADR-0012 foot Note names those two sentences and cites the rename; it decides nothing new and removes no line.Direction check
Every claim in both Amendments was re-read against
mainat20e59b2and the tag9f9eaa0by anchor (function, module, test name, changelog section), and every cite in the two new Notes was checked the same way.git diff origin/main -- docs/adr/removes exactly two lines, the two status lines whose word changes from proposed to accepted; everything else is appended at the foot of each file.Gate
The branch touches no gated path (
lib/,test/,config/,mix.exs,mix.lock), so there is no gate to run; CI runs it on the request. No changelog fragment: documentation and ADRs take none.