Skip to content

Accepts the two Amendments shipped in 0.24.0 - #253

Merged
johnnyt merged 1 commit into
mainfrom
sp-lbxd-flip-0-24-amendments
Oct 2, 2026
Merged

johnnyt merged 1 commit into
mainfrom
sp-lbxd-flip-0-24-amendments

Conversation

@johnnyt

@johnnyt johnnyt commented Oct 2, 2026

Copy link
Copy Markdown
Member

Accepts two Amendments whose code shipped in statifier_persistence 0.24.0 (tag v0.24.0 at 9f9eaa0), and adds a dated foot Note to each record. The flips are the conductor's, under the operator's standing campaign consent to flip a record whose code has shipped in a published version.

Records

ADR-0012, "the per-hash lock is keyed by the store, never by the tenant" (2026-09-29). Version 0.24.0; every claim checked at 20e59b2 (main; the one commit since the tag adds a Note to ADR-0012 and changes nothing in lib/ or test/). Checked: chart_lock/3 hashes chart_store/1's answer, a space and the content hash under @chart_lock_namespace, on Postgres only; chart_store/1 quotes __schema__(:source) and, when present, __schema__(:prefix), joined by a dot; supports_chart_retirement?/1 reads the same two values; fetch_retired_info/2 takes the lock shared and retire_chart/3 exclusive (lib/statifier_persistence/storage/ecto.ex); the charts unique index is on content_hash alone (lib/statifier_persistence/ecto/migrations/v01.ex, up/1) and no later migration changes it; the two named cases exist in test/statifier_persistence/ecto/retire_chart_race_test.exs over the hosts the Amendment names; the 0.24.0 changelog carries the Changed line.

ADR-0003, "every name the conformance suite defines in a host module carries one reserved prefix" (2026-09-29). Version 0.24.0; every claim checked at 20e59b2. Checked: every attribute and function the using block of lib/statifier_persistence/testing/storage_conformance.ex defines in the host module starts with conformance_, its nested modules with Conformance, and the one public function is conformance_forward_adapter_call/4; the moduledoc states the prefix contract, the generated test names and the six aliases with the two ways around them; test/statifier_persistence/storage/reserved_prefix_conformance_test.exs and test/statifier_persistence/storage/setup_ordering_conformance_test.exs hold what the Amendment says; the generated test names are the same set before and after the change, and the assertion lines differ only by the prefix; the 0.24.0 changelog carries the Changed line.

The retiring module's name. ADR-0012's accepted 2026-09-28 Amendment ("Pinned by.") and its 2026-09-29 Note ("The cases.") name the suite's nested module RetiringSerialization. The reserved-prefix change (20fb8bb) renamed it ConformanceRetiringSerialization, which is where it is defined on main. The ADR-0012 foot Note names those two sentences and cites the rename; it decides nothing new and removes no line.

Direction check

Every claim in both Amendments was re-read against main at 20e59b2 and the tag 9f9eaa0 by anchor (function, module, test name, changelog section), and every cite in the two new Notes was checked the same way. git diff origin/main -- docs/adr/ removes exactly two lines, the two status lines whose word changes from proposed to accepted; everything else is appended at the foot of each file.

Gate

The branch touches no gated path (lib/, test/, config/, mix.exs, mix.lock), so there is no gate to run; CI runs it on the request. No changelog fragment: documentation and ADRs take none.

Both 2026-09-29 Amendments shipped in statifier_persistence 0.24.0
(tag v0.24.0 at 9f9eaa0). Flips each Amendment's status word from
proposed to accepted in place, and adds a dated foot Note to each
record naming what was re-read at 20e59b2, which is main.

ADR-0012's Note also names the two earlier sentences that still call
the conformance suite's nested module RetiringSerialization, and cites
the reserved-prefix change (20fb8bb) that renamed it
ConformanceRetiringSerialization. It decides nothing new.

Only the two status lines are removed under docs/adr/. The branch
touches no gated path (lib/, test/, config/, mix.exs, mix.lock), so no
gate applies; CI runs it on the request.

Refs: sp-lbxd
@johnnyt
johnnyt merged commit ffd47cc into main Oct 2, 2026
1 check passed
@johnnyt
johnnyt deleted the sp-lbxd-flip-0-24-amendments branch October 2, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant