Repository navigation
Names the tests that pin the executing half - #140
Merged
Merged
Conversation
The comment above the cancelled-send test in timer_test.exs said the self-cancel test pins the `executing` half without naming a file. It now names both tests that pin it, each with its file: the live-queue self-cancel test in timer/self_cancel_test.exs and the query-level executing test in timer/cancellable_states_test.exs. Comment only; no test or behaviour changes. Refs: sob-sqk
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The comment above the test "a cancelled send never delivers: the drain after the cancel fires only the other send" in
test/statifier_oban/timer_test.exssaid "the self-cancel test pins theexecutinghalf" without naming a file. It now names both tests that pin that half, each with its file:test/statifier_oban/timer/self_cancel_test.exs(against a live queue)test/statifier_oban/timer/cancellable_states_test.exs(the query alone)Comment only: no test, assertion or
lib/line changes, so no changelog fragment (changelog.d/README.mdexcludes test harness changes).Review
Own in-turn review: the diff touches one comment block in one test file. Both quoted test names were matched verbatim against the named files on the branch. Both tests pin the
executinghalf: the self-cancel test asserts the executing job's own cancel answers{:ok, 0}and the row completes; the cancellable-states test forces a row toexecutingand assertscancel/3answers{:ok, 0}and leaves itexecuting. The "racing test above" the comment still refers to "a cancel racing execution: an already-run job stays run", which sits above it in the same file.Gate
Full
mix qualitygreen on the branch head (313 of 313 tests, on the branch rebased onto main, attested bymix quality.verify).Refs: sob-sqk