Skip to content

Names the tests that pin the executing half - #140

Merged
johnnyt merged 1 commit into
mainfrom
sob-sqk-self-cancel-comment-file
Sep 29, 2026
Merged

johnnyt merged 1 commit into
mainfrom
sob-sqk-self-cancel-comment-file

Conversation

@johnnyt

@johnnyt johnnyt commented Sep 29, 2026

Copy link
Copy Markdown
Member

What

The comment above the test "a cancelled send never delivers: the drain after the cancel fires only the other send" in test/statifier_oban/timer_test.exs said "the self-cancel test pins the executing half" without naming a file. It now names both tests that pin that half, each with its file:

  • "a delivery that cancels its own send_id is not killed by it" in test/statifier_oban/timer/self_cancel_test.exs (against a live queue)
  • "an executing timer is not cancelled: it has already fired" in test/statifier_oban/timer/cancellable_states_test.exs (the query alone)

Comment only: no test, assertion or lib/ line changes, so no changelog fragment (changelog.d/README.md excludes test harness changes).

Review

Own in-turn review: the diff touches one comment block in one test file. Both quoted test names were matched verbatim against the named files on the branch. Both tests pin the executing half: the self-cancel test asserts the executing job's own cancel answers {:ok, 0} and the row completes; the cancellable-states test forces a row to executing and asserts cancel/3 answers {:ok, 0} and leaves it executing. The "racing test above" the comment still refers to "a cancel racing execution: an already-run job stays run", which sits above it in the same file.

Gate

Full mix quality green on the branch head (313 of 313 tests, on the branch rebased onto main, attested by mix quality.verify).

Refs: sob-sqk

The comment above the cancelled-send test in timer_test.exs said the
self-cancel test pins the `executing` half without naming a file. It
now names both tests that pin it, each with its file: the live-queue
self-cancel test in timer/self_cancel_test.exs and the query-level
executing test in timer/cancellable_states_test.exs. Comment only; no
test or behaviour changes.

Refs: sob-sqk
@johnnyt
johnnyt merged commit e68c7d9 into main Sep 29, 2026
1 check passed
@johnnyt
johnnyt deleted the sob-sqk-self-cancel-comment-file branch September 29, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant