Notes on ADR-0008 that the lock moved and the requirements did not - #137
Merged
Merged
Conversation
A dated foot Note on ADR-0008 records that the accepted-note reading of mix.lock (statifier 2.7.0, statifier_persistence 0.13.0) held at eb47942 and 89adadd, and that since 839eac8 the lock resolves statifier_persistence 0.21.0, statifier 2.9.0 and, through statifier, predicator 9.4.2. The requirements in mix.exs are unchanged: {:statifier_persistence, "~> 0.13", optional: true} and {:statifier, "~> 2.5"}. Claims read at 839eac8. Additions only; the Note decides nothing and no Status line moves. Docs only: the diff is outside gate.build_paths, so the gate does not apply (the commit row's docs-only clause); no changelog fragment per changelog.d/README.md (ADRs excluded). Refs: sob-ne3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends a dated foot Note to ADR-0008 (the timer pin source over an optional persistence dependency). The accepted-note bullet "Consequences: both README sections name the optional edge" reads
mix.lockas carryingstatifier2.7.0 andstatifier_persistence0.13.0; since839eac8(the parked-timer test against the real store) the lock resolvesstatifier_persistence0.21.0,statifier2.9.0 and, throughstatifier,predicator9.4.2. The requirements inmix.exsdid not move. The Note decides nothing and moves no Status line; the diff is additions only (zero removed lines underdocs/adr/).Review (in-turn, tier gate). Every claim in the Note checked against
mainat839eac8:mix.lockresolvespredicator9.4.2 (line 25),statifier2.9.0 (line 27) andstatifier_persistence0.21.0 (line 28), and thestatifierlock entry requirespredicator~> 9.0, sopredicatorarrives throughstatifier; ateb47942and89adaddthe lock readstatifier2.7.0 andstatifier_persistence0.13.0;839eac8^still reads those two, and839eac8changesmix.lockand one test file only.mix.exscarries{:statifier_persistence, "~> 0.13", optional: true}indefp deps(line 83) and{:statifier, "~> 2.5"}instatifier_dep/0(line 111), unchanged since89adadd. The Context sentences above are untouched.Gate. Not run: the diff touches no path in
gate.build_paths(docs only), so the commit row's docs-only clause applies. No changelog fragment:changelog.d/README.mdexcludes ADRs.Refs: sob-ne3