Moves statifier_router to 0.10.0 - #179
Merged
Merged
Conversation
The router requirement moves to `~> 0.10.0`, the published release after 0.9.2, and `mix deps.update statifier_router` changes that one mix.lock line and no other. Nothing here needs more than 0.9.2: the new `:around_delivery` option is opt-in and no configuration sets it, and the Postgres reap statement is never reached on SQLite. The dependency-pin test asserts the new requirement and lock line, the routed recipe's first printed line names the loaded router 0.10, and the three guides' pin tables and floor sentences name 0.10.0. Refs: se-6ld8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The reference host moves to
statifier_router0.10.0, the published release after 0.9.2.mix.exs:{:statifier_router, "~> 0.10.0"}, with a dated comment in the form the line's earlier moves use.mix.lock:mix deps.update statifier_router(only that package) changed exactly one line, thestatifier_routerentry: version0.9.2to0.10.0, new inner and outer checksums. Its own requirements are unchanged (broadway ~> 1.3,ecto_sql ~> 3.14,predicator ~> 9.4,statifier ~> 2.10,statifier_persistence ~> 0.18,telemetry ~> 1.0,uxid ~> 2.0), and no other lock line moved:test/statifier_examples/mix_deps_test.exs: the router pin test asserts~> 0.10.0and a0.10.lock entry.docs/guides/basichttp-front.md,docs/guides/first-workflow.md,docs/guides/first-workflow-routed.md: each pins table names 0.10.0, since each says it lists whatmix.exsrequires andmix.lockresolves. The floor sentence in the BasicHTTP guide now says 0.10.0 is the floor because it is the published releasemix.exsrequires, and 0.9.2 was the first release that ran on this SQLite database. Each "moving" section gets one paragraph saying the move needed nothing.What the host meets
Nothing here needs more than 0.9.2. From the router's 0.10.0 changelog:
:around_deliveryis a new opt-in option. No configuration here sets it, so it wraps nothing.IN (...)list, and the routed recipe'sreapedstep counts the same rows.No migration version is added.
Provenance
test/statifier_examples/routed_workflow_test.exschanges one token. The routed recipe's first printed line names the loaded router version, and the test matched the prefixstatifier_router 0.9.. With 0.10.0 loaded it went red on that line alone, and every later line matched. It now matches0.10., as the move to 0.9.2 did with0.6.. The bump forced this edit; the bead's file list did not name it.Gate
Full
mix qualityon this tree (the commit's tree is byte-identical to the tree the run went green on, with the repo's gate lock and one machine slot held continuously from the run through the commit):Sabotage: I pointed the pin test's lock assertion back at
"0.9.and leftmix.lockalone.the statifier_router dep is the Hex requirementwent red on the=~assertion against the resolved 0.10.0 entry. I restored the file from a copy (byte-equal).Refs: se-6ld8