Adds a drafts shelf to the library loan fixture - #175
Merged
Merged
Conversation
No library-world fixture had a drafts shelf, so no Plan page test proved a tray reaches the description store. The loan now parks a second overdue notice on a shelf at its root, the store test counts tray among the kinds the two library fixtures draw, and the facts test checks the tray's and the parked step's words. The outline pin counts the two new rows. Refs: se-8lxc
johnnyt
force-pushed
the
se-8lxc-plan-drafts-shelf-test
branch
from
September 30, 2026 10:59
503f4a1 to
0a304c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
No library-world fixture carried a drafts shelf, so no Plan page test proved that a tray reaches the description store; the only fixture with a shelf is a card-processing one, outside the example domains new work uses.
priv/fixtures/library_loan.jsongains a drafts shelf as the last child of its root: a second overdue notice (core.sendofloan.overdue) parked for later, which never runs and is not compiled.plan_description_live_test.exs: the store test's@kindsnow includestray, so the two library fixtures between them must draw one; the facts test checks the tray's words ("Kept to one side: the steps here are not part of the flow") and the parked step's place ("kept to one side in Drafts").view_model_pin_test.exs: the loan's pinned outline counts the two new rows, the shelf as a step at the root and the parked step as a tray, with a dated comment.Provenance
priv/fixtures/, which the planned file list did not name; the bead's acceptance asks for a library-world fixture with a shelf, so the fixture edit is forced. The pin-test update is forced by it: that test pins every fixture's outline.@kinds; in the test the fixture list is@libraryand@kindsis the list of element kinds the two fixtures must draw between them.trayis added to@kinds.Checks
core.sequence, each turned the store test red on "no tray on the page" and the facts test red on the tray's words. The notes sit above the tests.mix qualitygreen on the committed tree: format, compile, credo, dialyzer, deps, and the full suite with coverage.In-turn review
I re-read the diff against the bead's acceptance: a library-world fixture carries a drafts shelf and a Plan page test asserts its tray kind is described. The shelf sits directly in the root's body, the one place a shelf is allowed, and the loan still carries one shelf. The parked step reuses an event the loan already sends, so the fixture declares no new event and stays in the library world. I ran the full suite before touching the pin: the pinned outline count was the only other test the fixture change moved, and it now counts the new rows.