Repository navigation
Carries the upgrading page to 0.42.1 - #689
Merged
Merged
Conversation
The page's range moves from 0.42 to 0.42.1. A standing paragraph under the pin advice says what moves at every release, a patch included: the compiler version, which Compiler.compiler_version/0 answers as the package's version and every CompilationRecord carries, so a host test that pins it moves its literal with each pin. The upgrade host in statifier_examples met exactly that at each step from 0.35.0 to 0.42.1 (its PR 191), and the page did not say it. "0.41 to 0.42" gains the 0.42.1 patch line: documentation only, NONE beyond that compiler version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries
docs/upgrading.mdfrom 0.42 to 0.42.1, with the one thing an upgrade host walking 0.35.0 to 0.42.1 had to change that the page did not say. Onlydocs/upgrading.mdchanges.What changes on the page
StatifierBlocks.Compiler.compiler_version/0answers the package's version and theStatifierBlocks.CompilationRecordin whatCompiler.compile/3answers carries it ascompiler_version, so a host test that pins it, or compares it with a stored record, moves its literal with each pin. It is said once, at the top, because it applies to every section.No other section is touched; the 0.38 pre-flight and the 0.39 note rollout bullets stand as written.
Evidence
The upgrade host in statifier_examples (its PR 191) moved statifier_blocks one minor per commit from 0.35.0 to 0.42.1. Its one forced edit outside
mix.exsandmix.lockwas a test match on the compile record'scompiler_version, moved at every commit, which that PR classes as intended but undocumented. Its palette pre-flight answered[]at 0.38.0 and at 0.42.1 for a palette whose block types areStatifierBlocks.InvokeSteptypes declared withfields:(each field:string) plus one hand-written type, and its stored document carries no note, so the 0.38 and 0.39 bullets needed no change for it.Direction check
Every claim on the new lines was read against the tags.
compiler.exat v0.42.1:@compiler_version "0.42.1",compiler_version/0documented as "this package's version", and the record built withcompiler_version: @compiler_version;compiled.excarries the record asrecord. At each tag v0.35.0, v0.35.1, v0.36.0, v0.36.1, v0.37.0, v0.38.0, v0.39.0, v0.40.0, v0.41.0, v0.42.0 and v0.42.1,@compiler_versionequals that tag's version, andcompiler_test.exs's "compiler_version is this package's version" asserts it againstmix.exs. The 0.42.1 CHANGELOG entry says it changes documentation only; the lib diff from v0.42.0 to v0.42.1 is that version string, two comment and moduledoc edits, and one private lookup in the editor rewritten to an equivalent helper (block_by_id/2, the sameDocument.blocks/1find).InvokeStep'sconfig_schema/1is built from itsfields:, so the 0.38 bullet's declared field types already cover such types. The diff removes two lines, the title and the opening sentence's version, both replaced.Gate
Full
mix qualitygreen on this commit's tree: Format, Compile, Doc links, Dependencies, ADR cites, Docs, Credo, Dialyzer, and Tests (3,954 of 3,954, 95.3% coverage). Doctor, Gettext and Sobelow skip as not installed, as the repo configures. No changelog fragment: the repo'schangelog.d/README.mdexcludes documentation.