Re-locates the Map-era code cites in ADR-0005, 0017 and 0018 - #685
Merged
Merged
Conversation
The changes to what the Map draws, the short-form comment in core.send and the editor's note lookup moved code lines that three accepted records cite. One dated foot Note per record re-locates each drifted cite by its anchor, read at d38dfb9, and names the cites that have not moved: ADR-0018's cites into map/info.ex, editor/map_regions.ex, the Map hook, describe.ex and editor.ex; ADR-0017's flip-Note cites into core/send.ex, block_type.ex, palette.ex and describe.ex; ADR-0005's cites from the decision 7 Amendment on, into the Map hook, map_regions.ex, editor.ex, inspector.ex, edit.ex and their tests. No line is removed and no record decides anything new. Record Notes only; no changelog fragment (changelog.d/README.md excludes ADRs). Gate: full mix quality green on this exact staged tree (3,954 of 3,954 tests, 95.3% coverage, dialyzer and credo clean, ADR cites green). Refs: sb-062y
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The changes to what the Map draws, the short-form comment in
core.sendand the editor's note lookup moved code lines that three accepted records cite. This adds one dated foot Note to each record, re-locating each drifted cite by its anchor, read atd38dfb9(the currentmain), and naming the cites in the same sections that have not moved:map/info.ex(def elements,def idle,defp starts,defp notes,defp findings),editor/map_regions.ex(def map_region,def description_region), the Map hook (export const StatifierBlocksMap, its onethis.pushEvent), Context'sdef outlineindescribe.ex, anddefp describable?ineditor.ex. The Note on selection's cites ofhover/2at9a324a2describe code that is gone and are left as written, as the new Note says.core/send.ex(def sentence,@short_form,def delay_words),block_type.ex,palette.exanddescribe.ex.map_regions.ex,assets_test.exs,map_layout_test.exs,README.mdsections), the note-command Amendment and its flip rows (handle_event("note-change", ...)now ateditor.ex:1850,inspector.ex,edit.ex,note_field_test.exs), the shell Amendment and its flip rows (map_regions.ex,describable?,map_regions_test.exs), and the two Notes on the Map hook below them. Cites above that Amendment are not re-read, as the Note says.The ADR-0005 Note also records, without reading it against clause 7f, that
draw()now sets athis.warnedNoCanvasflag, which the Note of 2026-09-29 on what the hook keeps does not list.git diff origin/main -- docs/adr/shows zero removed lines; each Note is appended at the end of its file.mix adr.citesis green (every record citation resolves and is unmoved; the advisories are unchanged and none is on the new lines), so there is no baseline refresh to commit.No changelog fragment:
changelog.d/README.mdexcludes docs and ADRs.Gate
Full
mix qualitygreen on the exact staged tree committed (3,954 of 3,954 tests, 95.3% coverage, dialyzer, credo, docs and ADR cites clean).In-turn review
Direction check of the record text: each re-located line was read at
d38dfb9by grepping the named anchor in the named file, and each "placed at" line was read from the record itself, with the older reading checked at its stated commit where a line had been placed twice (describe.ex'sdef outlineatff04855,362a0e9and9adc029; the hook's lines at2469e01;map_regions.exat8c4d61b). Every anchor still names the thing the record says. Each Note opens as a dated Note carrying noStatus:line, decides nothing, amends no clause and edits no line above it; the flip Notes are corrected only by the further Note, never rewritten. The diff is additions only, indocs/adr/only.Out of scope and left as found:
ADR-0016's flip-Note cites intodescribe.exinclude several that have moved by one line since520c6d8; they are not cites into the Map files, and that record is not changed here.