Repository navigation
Notes the outcome of an edit in ADR-0005's Note textarea - #684
Merged
Merged
Conversation
The Amendment of 2026-09-29 that adds clause 2s says the editor turns the textarea's note-change event into one update_note command "through the same funnel as every other command", which walks from the event to the command. A dated foot Note states the outcome instead, each claim with one anchor: one change is one update_note command, and one undo entry. The Amendment is not edited, and no line is removed. Gate: full mix quality green on this staged tree (3,954 of 3,954 tests, 95.3% coverage, dialyzer clean, ADR cites green). Refs: sb-0suc
johnnyt
force-pushed
the
sb-0suc-adr-0005-note-command-outcome
branch
from
September 30, 2026 11:31
5c6d0b2 to
5a4cf23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ADR-0005's Amendment of 2026-09-29, which adds clause
2s({:update_note, id, note}), says under "The editor's field" that the editor turns the textarea'snote-changeevent into one{:update_note, id, note}"through the same funnel as every other command". The phrase walks from the event to the command instead of stating what the edit produces.This PR appends one dated foot Note to
docs/adr/0005-liveview-editor.mdthat states the outcome only, one anchor per claim: one change in the Note textarea is one{:update_note, id, note}command, and one undo entry. The Amendment is not edited; the Note carries no Status line and decides nothing.git diff origin/main -- docs/adr/shows 25 added lines and zero removed. No changelog fragment:changelog.d/README.mdexcludes docs and ADRs.Refs: sb-0suc
Gate
Full
mix qualitygreen on the committed tree (3,954 of 3,954 tests, 95.3% coverage, dialyzer clean).mix adr.cites: every record citation resolves and is unmoved, with the advisory count unchanged by this Note.Review (in-turn, direction check of the record text)
Every claim was checked against the repo at
4a70851(main when this branch was cut). The quoted phrase is at:13828-13829of the record.def handle_event("note-change", ...)(editor.ex:1850) commits exactly one{:update_note, id, note}when the posted note differs from the block's current one, and nothing when it equals it. The test "a change that moves nothing commits nothing" (note_field_test.exs:87) holds the second, and the test "a change applies the command, and undo and redo move the note" (note_field_test.exs:66) holds the undo claim: one undo after one change restores the prior note and one redo restores the change. The Note narrates no call path and cites the function, not the route. It is appended at the end of the file, so no line another record cites moves. Nothing rejected.