Skip to content

Notes how ADR-0005's hover row and clause 7f read against the layer - #681

Merged
johnnyt merged 1 commit into
mainfrom
sb-4f9n-adr-0005-hover-row
Sep 30, 2026
Merged

johnnyt merged 1 commit into
mainfrom
sb-4f9n-adr-0005-hover-row

Conversation

@johnnyt

@johnnyt johnnyt commented Sep 30, 2026

Copy link
Copy Markdown
Member

What

ADR-0005's Note of 2026-09-28, which flips the three Amendments of that date, answers clause 7f's "draws what the server computed" with a row whose last clause says the Map hook's hover "swaps and restores the description region's text from the store the server rendered". Since ADR-0018's Note of 2026-09-29 ("selection speaks, hover is silent") the hook draws a hover in a separate hover layer and never writes the region; the Note of 2026-09-29 on ADR-0005 that lists the hook's hover handlers reads them against "holds no behaviour" only.

This PR appends one dated foot Note to docs/adr/0005-liveview-editor.md saying how that row, clause 7g's hover sentence and clause 7f's second permitted write ("a swap of one server-rendered text for another in a region the server rendered, put back when the pointer leaves") read against the layer. The Note carries no Status line, decides nothing, and edits no line above it: git diff origin/main -- docs/adr/ shows 78 added lines and zero removed. No changelog fragment: changelog.d/README.md excludes docs and ADRs.

Refs: sb-4f9n

Gate

Full mix quality green on the committed tree (3,951 of 3,951 tests, 95.3% coverage, dialyzer clean, ADR cites green: every record citation resolves and is unmoved).

Review (in-turn, direction check of the record text)

Every claim was checked against the repo at 4fdf7f8 (main when this branch was cut), and every code cite is anchor first, line second. def description_region (map_regions.ex:227) renders the layer with the region's id plus -hover, aria-hidden="true", hidden and phx-update="ignore" (:259) inside sb-map__description-frame. export function hover (statifier_blocks_map.js:740) shows by copying the store entry's markup into the layer, setting data-map-hover and unhiding it (:755-757), and restores by hiding, emptying and dropping the mark (:744-746); no line of it looks the region up. The CSS rule headed .sb-map__description-hover:not([hidden]) + .sb-map__description (statifier_blocks.css:5036) sets the region's opacity: 0 while the layer shows. The tests named in the Note exist at the cited lines: map_hover_test.exs:62 and :149, map_regions_test.exs:404. The record cites :13684, :13706 and :14107 are the flip Note's heading, the row and the later Note's heading at 4fdf7f8. The Note reads the clause, it does not change it: the clause's three permitted writes stand, and the hover write is read as the second, done in an element the server keeps out of patching. It is appended at the end of the file, so no line another record cites moves. Considered and rejected: treating the data-map-hover attribute as a fourth kind of write (it is written on the same server-rendered element as the swap and dropped by the same restore, so it is read as part of the swap, as the earlier Note of 2026-09-29 already describes it).

The flip Note of 2026-09-28 answers clause 7f's "draws what the server
computed" with a row saying the hook's hover swaps and restores the
description region's text. The hook now draws a hover in a separate
layer the server renders beside the region, and never writes the region.
A dated foot Note says how that row, clause 7g's hover sentence and
clause 7f's second permitted write read against the layer: the swap
happens in the layer, an element the server rendered and keeps out of
patching, and the clause holds as written. No line above it is edited.

Gate: full mix quality green on this staged tree (3,951 of 3,951 tests,
95.3% coverage, dialyzer clean, ADR cites green).

Refs: sb-4f9n
@johnnyt
johnnyt force-pushed the sb-4f9n-adr-0005-hover-row branch from 1120288 to c62d2e4 Compare September 30, 2026 11:20
@johnnyt
johnnyt merged commit 0bcbe1d into main Sep 30, 2026
2 checks passed
@johnnyt
johnnyt deleted the sb-4f9n-adr-0005-hover-row branch September 30, 2026 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant