Moves the dev dependency to ex_quality 0.15.1 - #169
Merged
Merged
Conversation
ex_quality 0.15.1 fixes the Docs stage: 0.15.0 counted only ExDoc warning lines that start with "warning:", and ExDoc 0.40 on Elixir 1.18 indents them, so the stage could report no warnings over docs that warned. 0.15.1 reads both shapes and passes --warnings-as-errors to mix docs. The mix.exs constraint (~> 0.15) already admits 0.15.1, so only the ex_quality line in mix.lock moves. The fixed stage reports no warnings here, and MIX_ENV=dev mix docs --warnings-as-errors exits 0, so no docs change is needed. A missing-function reference added to a guide and then removed turned the Docs stage red, so the stage now discriminates. Refs: sui-64yg
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the dev-only
ex_qualitydependency from 0.15.0 to 0.15.1 (bead sui-64yg).Why
ex_quality 0.15.1 fixes the Docs stage. 0.15.0 counted only ExDoc warning lines that start with
warning:; ExDoc 0.40 on Elixir 1.18 indents them, so the stage could report no warnings over docs that did warn. 0.15.1 reads both shapes and passes--warnings-as-errorstomix docs.What changed
mix.lock: theex_qualityline only (0.15.0 to 0.15.1, both hashes). No other lock line moved.mix.exsis unchanged: its constraint~> 0.15already admits 0.15.1.skip_undefined_reference_warnings_on: ["CHANGELOG.md"]stays as it was; no skip was added.changelog.d/README.mdexcludes quality gate and tooling changes.Verification
mix deps.update ex_qualityresolved 0.15.1 from Hex.MIX_ENV=dev mix docs --warnings-as-errorsexits 0 with no warning lines.mix qualitygreen with the Docs stage on 0.15.1 ("Docs: No warnings"), andmix quality.verifyattests a full run (scope all, no profile). Gettext and Sobelow are the repo's two declared not-applicable skips.Review
Tier: gate. The diff is one
mix.lockline for a dev-only dependency; it touches no public function, module, option, callback, wire shape or fixture, and is far under the size threshold. In-turn review: I re-read the diff against the bead's acceptance. The lock resolves 0.15.1 from Hex under an admitting constraint, and only theex_qualityline moved. The full gate is green with the fixed stage.mix docs --warnings-as-errorsexits 0, so there were no warnings to fix and no skip list was needed. This repo's CLAUDE.md asks for no gate-change log entry or record for a tooling change. There is no version bump. No record underdocs/adr/is touched.