Repository navigation
Accepts the term-order member amendment - #205
Merged
Merged
Conversation
The value-domain record's amendment on more members compared as the reference's term order compares them, with its section on a leading member that is the null value itself, shipped in @riddler/predicator 0.6.0. Its status flips to accepted in place, and a dated foot Note records the flip, the commit every claim was verified at (7c93e9c, the v0.6.0 tag), what was checked, and who decided each part. No other line changes. Refs: pts-lspz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips the value-domain record's amendment of 2026-10-04 to accepted now that
@riddler/predicator0.6.0 is on npm (dist-tags.latestreads 0.6.0).The record
docs/adr/0002-the-value-domain-and-the-host-boundary.md, "Amendment: more members compare as the reference's term order compares them (2026-10-04)", with its appended section "A leading member that is the null value itself (added 2026-10-04)". Its code landed in requests 186 and 187 and is in the commit taggedv0.6.0(7c93e9c), which is the head ofmainat the flip.7c93e9c. No commit after the change touchessrc/evaluator.ts, the reference transcript or the three tests the amendment names.membersEqual,isDateAgainstDateTime,looseEqualand itsbyInstantflag,valuesEqual,compareOrder,heldMember,nullMemberOrder, the evaluation'shalt, andPDateTime's fields). Every row of every table in the amendment was run, not read: this package's columns against the published 0.5.0 (Before) and 0.6.0 (Now, This package) builds, and the Reference column in a detached export of predicator-exv9.4.2under Elixir 1.18.3 and OTP 27; every cell matched. The inequalities beside the equality rows, strict equality of the member pairs, the "What this does not decide" ordering, the top-level null value, and the "What this does not change" paragraph were run the same way and hold. The reference's cited clauses (compare_values/3andvalues_equal?/2, thetypes_matchclause, and the date-against-datetime clauses) and itsdocs/isa.mdsection 5 list-ordering sentence were read at the tag. The transcript rowsdate-member/001-054andnull-order/001-044are present with the source pinned atv9.4.2, the declared rows are declared with both answers, andtest/date-member.test.ts,test/null-order.test.tsandtest/reference-transcript.test.tspass at the head.The amendment's body does not name its own status, so no sentence of it has to be met in the Note.
The change
accepted (2026-10-04; proposed 2026-10-04), in place, in the form the record's earlier flips use.git diff origin/main -- docs/adr/removes one line, the old Status line; nothing else is removed.Docs only: no TypeScript and no gated path is touched, so the repository's docs-only rule applies and no changelog fragment is written. CI runs the full gate.