Repository navigation
Accepts two 0.7.0 amendments at 1fcb204 - #127
Merged
Merged
Conversation
Flips the Status lines of ADR-0004's Amendment of 2026-09-29 (a from: of this package's own type that declares legacy: is not silent) and ADR-0005's Amendment B (:root_vault required only when :gcp_kms is absent) from proposed to accepted (2026-09-30), in place. Both code halves shipped in encryptor_ecto 0.7.0 (tag v0.7.0 at 1fcb204), and a dated Note at each record's foot lists what was re-verified there. The records' own Status lines and index rows do not change; the index gains a paragraph naming the two amendments. No line is removed but the two status lines. Refs: ece-vvez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flips two amendments whose code shipped in
encryptor_ecto0.7.0 from proposed to accepted, one per record, each with a dated foot Note. Docs only (docs/adr/); no changelog fragment, and no quality gate applies (the repo's docs-only rule: a change touching no Elixir code has no gate to run).Every claim was re-verified against
mainat1fcb204, the commit taggedv0.7.0and published on Hex as 0.7.0.ADR-0004, "Amendment (2026-09-29): a
from:of this package's own type that declareslegacy:is not silent". Code half: the**Breaking**entry of the[0.7.0]changelog section. Claims checked::legacyis among the keysfrozen_params?/1requires (Encryptor.Ecto.Migrator.Source), sovault_backed?/2still answerstruefor a declaration withlegacy:;source_authenticated!/4returns a declared boolean as declared, andundeclared_source!/3raises aCompileErrorthroughraise_at!/2naming the field, thefrom:type and thelegacy:module (undeclared_legacy_message/3); a vault-backedfrom:naming nolegacy:module still compiles silent;vault_backed?/2changed in its doc only and@field_optionsis unchanged betweenv0.6.0andv0.7.0; the exit guide's section "If you must go back: the reverse plan" andEncryptor.Ecto.Binary's moduledoc section "The migration window::legacy" exist; the three tests the Note names are intest/encryptor/ecto/migration_test.exs.ADR-0005, "Amendment B (2026-09-29):
:root_vaultis required only when:gcp_kmsis absent". Code half: theAddedentry of the[0.7.0]changelog section. Claims checked, also againstencryptorv0.6.0(91e9643), the version 0.7.0 pins:root_vault/1(Encryptor.Ecto.KeyStore) answers{:ok, nil}only when:root_vaultis absent and:gcp_kmspresent, otherwisemodule_option/2refuses as before; thestate/0type readsroot_vault: module() | nil; the%{root_vault: nil}clause ofunwrap_row/4answers{:invalid_key_descriptor, {:no_root_vault, "engine_message"}}for a row with nokey_id, and a row carrying one still answers:unexpected_key_id;t:Encryptor.Provider.reason/0carries{:invalid_key_descriptor, term()}, so nothing widens; the root vault is read byunwrap_row/4alone once placed in the state; the shipping commit changes no stored string; the named describe blocks are in the two key-store test files.Shape. Each Amendment's Status word flips in place, as the earlier flips in these records did (ADR-0005's Amendment A). Each foot Note closes with its provenance line. The index table is unchanged (both rows already read "with amendments"); a paragraph naming the two amendments follows the precedent paragraph for the 0.6.0 flips.
git diff origin/main -- docs/adr/removes exactly the two Status lines.Review. In-turn review against the bead's acceptance: every claim above was read at the anchor named, the removed-line count checked, and each Amendment's own "no status word above flips" sentence is met in its foot Note rather than reworded. The cold direction pass is still to run.
Refs: ece-vvez