Repository navigation
Adds Notes on three stale ADR sentences - #120
Merged
Merged
Conversation
Appends one dated foot Note to each of ADR-0005, ADR-0006 and ADR-0007; no line above any Note is changed. ADR-0007: the Context's "a host writes it by hand" describes the GCP guide before it moved to shred/3 (4e9deb2, shipped in 0.6.0). ADR-0006: the key-store generators carry four owner-noun sentences, not the one the acceptance Note quoted; each is anchored and read as text about the kept column and index. ADR-0005: A4's two 0.4.1 claims read at the 0.5.0 pin; three readings of the 2026-09-14 Note (its section 2's advice, the under-scoped count cite, the crypto_key_name head rendering); and how a count in this file is read. Refs: ece-tdw0, ece-few
johnnyt
force-pushed
the
ece-tdw0-adr-flip-note-stale-sentences
branch
from
September 30, 2026 05:58
6adeb31 to
1804465
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Appends one dated foot Note to each of ADR-0005, ADR-0006 and ADR-0007, meeting a stale sentence in each. Docs-only: no line above any Note changes (
git diff origin/main -- docs/adr/shows additions only), no status word flips, no changelog fragment, nolib/change.Beads: ece-tdw0, with ece-few folded in (both are ADR-0005 foot-Note fixes; the one ADR-0005 Note serves both).
What each Note says
Encryptor.Ecto.KeyStore.shred/3and warns against a hand-writtendelete_all. The guide changed in4e9deb2, an ancestor ofv0.6.0.tenant_refcolumn and its index (decision 3, W1 and W2). It also names the quotation of encryptor's P3 step 2 in the comment aboverecheck/5, added after the acceptance.crypto_key_namehead drops the trailing comma of a two-line head. Section 3 states how a count in this file is read: scoped to the lines and SHA it names.Direction check (in-turn review)
Every claim was checked against
encryptor_ectomain andencryptortags before the PR opened. ADR-0007: the guide at the record's own commit taughtMyApp.Repo.delete_all(; the guide on main callsshred/3and carries the "takes no lock, waits for no drain and leaves no record" sentence;git merge-base --is-ancestor 4e9deb2 v0.6.0succeeds. ADR-0006:grep -n tenantover the two generators, excludingtenant_ref, gives exactly the four lines the table anchors (:9,:69,:134of the key-store generator,:72of the shape generator);git diff ad08848 HEADover both generators is empty;lib/encryptor/ecto/key_store.ex:717sits in the comment abovedefp recheck, came in withaa78d82, and its quoted words match step 2 of P3 in encryptor'sdocs/adr/0005-rotation-and-crypto-shred.md. ADR-0005:mix.exspins{:encryptor, "== 0.5.0"}; at encryptorv0.5.0(9ad74e2)Encryptor.Provider.GcpKmshas publicinit/1anddecryption_keys/2, and the privateunwrap/3's{:error, _failure}arm answers{:key_unavailable, selector}; atv0.4.1(4c8fbe9)crypto_key_name's head isgcp_kms.ex:376, ending in a comma, withdo:on:377, and atv0.5.0it is:379in the same form; the three quoted phrases of the 2026-09-14 Note are verbatim. The ADR-0005 Note names none of the strings the earlier counts count, so it moves none of them. Tier: gate (docs-only, no contract surface, under the size threshold).Provenance
docs/adr/README.md.e3581e6) that touches none of the files this PR changes or cites.