Improve 🧂 SonarQube default admin password#159
Merged
Conversation
This is absolutely the worst workaround to prepare for redhat-cop/helm-charts#659
This makes the sonarqube API usage more future-proof.
Member
|
I just left a comment at the helm chart repo, @kareiva. And is there any screenshot changes needed in the chapter https://rhoai-mlops.github.io/lab-instructions/#/8-the-supporting-acts/4-code-analysis? thanks! |
Contributor
Author
|
@ckavili |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the SonarQube out-of-date warning go away.
This should be safe to merge, tested locally, and docsify renders it nicely.
Then we can bump the sonarqube version here or somewhere in between: redhat-cop/helm-charts#659
Tested ✅ on cluster-dqn7k.dqn7k.sandbox3357
The password needs to fulfill the following requirements: at least 12 characters and contain at least one uppercase character, one lowercase character, one digit and one special character.
So I have picked _ as the safest-possible choice (+ and # do not work as they are not URL-safe)
Hope it makes sense. 🤞