Conversation
Add `inst.ks.cert` for importing a PEM CA certificate into the initramfs trust bundle before network kickstart downloads. This follows the trust-store update principle used by `%certificate --type=anchor`, but makes the certificate available before the kickstart is read. This change allows for easier building of `netboot.iso` with customized bootloader configuration and custom cert for full end-to-end TLS provisioning. The only option today is to rebuild initramdisk, with this change `mkksiso` utility can be used. I considered adding a more useful `inst.cert` that could be then used also by other features like `inst.stage2`, however, there were queue synchronization issues. For this reason, I kept the feature small. Also, instead of passing the certificate explicitly to the download utility, the cert is simply appended to the bundle.
rvykydal
self-requested a review
September 21, 2026 10:00
Contributor
|
Thank you for contribution. I am going to discuss the added API with the team, then I'll review the suggested implementation. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
inst.ks.certfor importing a PEM CA certificate into the initramfs trust bundle before network kickstart downloads. This follows the trust-store update principle used by%certificate --type=anchor, but makes the certificate available before the kickstart is read.This change allows for easier building of
netboot.isowith customized bootloader configuration and custom cert for full end-to-end TLS provisioning. The only option today is to rebuild initramdisk, with this changemkksisoutility can be used.I considered adding a more useful
inst.certthat could be then used also by other features likeinst.stage2, however, there were queue synchronization issues. For this reason, I kept the feature small. Also, instead of passing the certificate explicitly to the download utility, the cert is simply appended to the bundle.I haven't tested yet, want to hear from you guys what you think. I explored many ideas for this but ultimately landed on this.
Code conventions. tl;dr: Follow PEP8, wrap at 100 chars, and provide docstrings.
Commit message conventions. tl;dr: Heading, empty line, longer explanations, all wrapped manually. If in doubt, write a longer commit message with more details.
Tests pass and cover your changes. You can run tests locally manually, or have them run as part of the PR. A team member will have to enable tests manually after inspecting the PR.
Release notes and docs if the PR adds something major or changes existing behavior.
RHEL rules: If your PR is for a
rhel-*branch, pay special attention to commit messages. Make sure all commit messages include a line linking the commit to a bug, such asResolves: RHEL-123456. For more information, see the complete rules.