Repository navigation
Conversation
Currently if we find the MODSIGN eku on a cert, we return that the cert can't be used, but in doing so we leak the parsed certificate objects from OpenSSL. They get cleaned up when our arena is freed, of course, but it's still wrong. This fixes it to free them before returning. Signed-off-by: Peter Jones <pjones@redhat.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #832 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 24 24
Lines 4223 4223
Branches 654 654
=======================================
Hits 2490 2490
Misses 1462 1462
Partials 271 271 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if we find the MODSIGN eku on a cert, we return that the cert can't be used, but in doing so we leak the parsed certificate objects from OpenSSL. They get cleaned up when our arena is freed, of course, but it's still wrong.
This fixes it to free them before returning.