Repository navigation
pe: Fix PF in GRUB after memattrs call - #772
Merged
Merged
Conversation
Contributor
Author
|
The three test failures are build errors and don't seem to be related to the change here. |
rosslagerwall
force-pushed
the
private/rossla/memattrs
branch
from
August 15, 2025 16:47
ccf3051 to
e2fbcd2
Compare
Contributor
Author
|
I've updated the PR with another case that I found (and added Fixes tags). |
8 tasks done
The call to update_mem_attrs() takes an aligned pointer within an allocated region but passes the entire size of the allocated region. The result is that Shim may remove execute permission from some pages belonging to GRUB causing a page fault upon returning from the LoadImage call. There are two cases: * When loading the image, set the memory attributes for exactly what we intend to load. * When freeing the image, be cautious and apply the edk2 workaround for the entire allocated region. Fixes: 226fee2 ("PE Loader: support and require NX") Fixes: 2f64bb9 ("loader-protocol: add workaround for EDK2 2025.02 page fault on FreePages") Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
vathpela
force-pushed
the
private/rossla/memattrs
branch
from
October 1, 2026 20:17
e2fbcd2 to
21893c1
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #772 +/- ##
=======================================
Coverage 58.96% 58.96%
=======================================
Files 24 24
Lines 4223 4223
Branches 654 654
=======================================
Hits 2490 2490
Misses 1462 1462
Partials 271 271 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The call to update_mem_attrs() takes an aligned pointer within an allocated region but passes the entire size of the allocated region. The result is that Shim may remove execute permission from some pages belonging to GRUB causing a page fault upon returning from the LoadImage call.