Add --google-takeout-flagged-labels#51
Open
poldy79 wants to merge 1 commit into
Open
Conversation
By default only Important mails are marked as flagged. Add an option to provide a comma separated list of labels to specify which mails will be marked as flagged.
| google_takeout_language="en", | ||
| debug=False, | ||
| google_takeout_flagged_labels="", | ||
| debug=False |
Contributor
There was a problem hiding this comment.
Does this even run?
Shouldn't debug=False be debug=False, (with a comma) as it's not the latest parametre?
Contributor
Author
There was a problem hiding this comment.
sorry - had to rebase and did not test... will fix that..
| self.google_takeout_first_label = google_takeout_first_label | ||
| self.google_takeout_label_priority = google_takeout_label_priority | ||
| self.google_takeout_language = google_takeout_language | ||
| self.google_takeout_flagged_labels = google_takeout_flagged_labels.split(',') |
Contributor
There was a problem hiding this comment.
What about someone using:
--google-takeout-flagged-labels='"My spaced label","My spaced with commas, label", "NonSpacedLabel"' ?
Please check csv_file in the current code where I implemented a parser for these edge-corner cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default only Important mails are marked as flagged. Add an option to
provide a comma separated list of labels to specify which mails will be
marked as flagged.