Skip to content

build(webapi): upgrade to ReScript 13 alpha.7 [Codex] - #414

Merged
jderochervlk merged 1 commit into
mainfrom
build/rescript-alpha-7
Nov 16, 2026
Merged

jderochervlk merged 1 commit into
mainfrom
build/rescript-alpha-7

Conversation

@jderochervlk

Copy link
Copy Markdown
Collaborator

Upgrade the compiler baseline before continuing the private-record migration in #404. ReScript 13.0.0-alpha.7 includes rescript-lang/rescript#9125, which rejects coercion from another type into a private record—the loophole reproduced on alpha.5 in #403.

Pin the development compiler and raise the minimum peer version to alpha.7, update the lockfile and installation guidance, and reject the former alpha.5 baseline in packed-consumer checks. Add a regression for forged Response coercion alongside positive coverage for native construction, direct field reads, outward coercion, and the existing File-to-Blob helper. This does not introduce package-wide native-record privacy.

The upgrade also requires a concrete typed-array operation in the ImageData fixture and support for the compiler's new documentation parameter/type schema. Preserve rendered signatures and type links, including callbacks, tuples, and generic parameters. The changes across 40 existing ReScript files are the new compiler's formatting output.

Alpha.7 no longer supports native compilation on Intel Macs (darwin-x64); the migration notes and project status call out that compatibility break.

Refs #403. This is the prerequisite branch for #404, not the private-record migration itself.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T21:05:57.889422Z 04a8b4d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@jderochervlk
jderochervlk merged commit 014e7d9 into main Nov 16, 2026
4 checks passed
@jderochervlk
jderochervlk deleted the build/rescript-alpha-7 branch November 16, 2026 21:08
jderochervlk added a commit that referenced this pull request Nov 17, 2026
React's DOM bindings need element, history, and location types, but
History and Location currently belong to the Window feature. Selecting
those types therefore also compiles the broader Window dependency graph.

Add independent `WebAPI.History` and `WebAPI.Location` features and move
their source files into their own directories. History depends only on
the standard library; Location depends on core DOM. Window includes both
features, preserving existing module names and type identities.

Consumers can select `WebAPI.DOMNodes`, `WebAPI.History`, and
`WebAPI.Location` without enabling Window. The feature-ownership checks
register both new source groups and guard missing features and duplicate
public-module ownership. The API guide documents the narrower selection.

The compiler upgrade has already landed in #414. This branch now
incorporates that main-branch update and retains its compiler checks,
documentation renderer, and typed-array fixture. The remaining diff is
limited to the History/Location feature split, its documentation, and
feature validation.

The further selective DOMTree/CSS layout is separate in #415; the React
profiling and dependent JSX work remain in
jderochervlk/rescript-react#1 and
jderochervlk/rescript-react#2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant