fix: apply RTL direction class in the page editor#8031
Open
nabaco wants to merge 2 commits into
Open
Conversation
added 2 commits
June 17, 2026 23:02
The reader view (themes/default/components/page.vue) sets `is-rtl`/`is-ltr` on the root `v-app` from `$vuetify.rtl`, so all `.is-rtl` content styles apply to rendered pages. The editor's root `v-app` (components/editor.vue) was missing this class, so for RTL the CKEditor "Visual" editor rendered content left-to-right, so list bullets stayed on the left. I copied the reader's binding so the editor inherits the same `.is-rtl` content rules.
The content list-bullet rule (themes/default/scss/app.scss) draws a custom `::before` bullet on `ul` and excludes `.contains-task-list` (markdown task lists, where the checkbox is the marker). The CKEditor "Visual" editor emits task lists with class `.todo-list`, which was not excluded, so the bullet rendered in the task-list checkbox - in both the editor and the saved/rendered output. Exclude `.todo-list` as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: Hebrew (RTL) text in the visual editor didn't play well with bullet lists/todo lists.
The reader view (themes/default/components/page.vue) sets
is-rtl/is-ltron the rootv-appfrom$vuetify.rtl, so all.is-rtlcontent styles apply to rendered pages. The editor's rootv-app(components/editor.vue) was missing this class, so for RTL the CKEditor "Visual" editor rendered content left-to-right, so list bullets stayed on the left. I copied the reader's binding so the editor inherits the same.is-rtlcontent rules.The content list-bullet rule (themes/default/scss/app.scss) draws a custom
::beforebullet onuland excludes.contains-task-list(markdown task lists, where the checkbox is the marker). The CKEditor "Visual" editor emits task lists with class.todo-list, which was not excluded, so the bullet rendered in the task-list checkbox - in both the editor and the saved/rendered output. Exclude.todo-listas well.Result:
