-
Notifications
You must be signed in to change notification settings - Fork 191
[#2524] Add new --author-dedup-mode flag for deduplicating authors #2532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
97d7077
[#2524] Add new --author-dedup-mode flag for deduplicating authors
yizhong187 51cfbe2
[#2524] Add dedup-author-mode flag in user guide
yizhong187 71b1408
[#2524] Add warning for wrong uses of author-dedup
yizhong187 cc9a476
[#2524] Extract gitId to local variable in ReportGenerator
yizhong187 eb0f9c7
[#2524] Fix styling issue
yizhong187 976fba3
[#2524] Fix styling issue
yizhong187 c9ff151
Merge branch 'master' into author-dedup-mode
CYX22222003 7803e26
Merge branch 'master' into author-dedup-mode
CYX22222003 1db88fe
[#2524] Add test
yizhong187 f988ea8
[#2524] FIX CHECKSTYLE
yizhong187 3ee7695
[#2524] Add new line at EOF
yizhong187 dcf8f76
Merge branch 'master' into author-dedup-mode
yizhong187 a3edd20
Merge branch 'master' into author-dedup-mode
yizhong187 65ada75
Merge branch 'master' into author-dedup-mode
CYX22222003 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's no validation to ensure that the --author-dedup-mode flag is used correctly. According to the documentation, this flag "must be used in conjunction with the --config flag and requires an author-config.csv file to be present." However, the code doesn't enforce this requirement.
If a user specifies --author-dedup-mode with --repos (instead of --config), or if they use --author-dedup-mode with --config but no author-config.csv exists, the flag will be silently ignored without any warning or error message. This could lead to user confusion.
Consider adding validation in ArgsParser.parse() to check if isAuthorDedupMode is true, and if so, verify that:
Alternatively, you could add a warning log in ReportGenerator.updateAuthorList() when isAuthorDedupMode is true but the conditions aren't met.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yizhong187 agreed, and i think it should just be limited to a warning. meaning if dedup flag is used but config flag is absent or config csv is absent, you can consider displaying a warning saying the dedup flag will be ignored. giving an error might be too much
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed!