[#1166] Set up GitHub Actions by Tejas2805 · Pull Request #1168 · reposense/RepoSense

Tejas2805 · 2020-03-19T21:11:56Z

First-time contributors have a difficult time matching RepoSense's 
contribution guidelines and it becomes the onus of the senior 
developers to manually check and guide them.

Let's automate this process by using Github Actions to leave a comment 
and guide them on how to match our guidelines. 
Let's also automate other housekeeping tasks such as auto-closing
inactive PRs.

Tejas2805 · 2020-03-20T09:55:25Z

@damithc Need your review on this.

I have kept it at 30 days for now before declaring it stale and 7 more days before closing it.

damithc

Added some comments.

0blivious · 2020-03-23T10:14:24Z

+      with:
+        repo-token: ${{ secrets.GITHUB_TOKEN }}
+
+        pr-message: 'Thank you for submitting this PR. Please double-check to ensure that you have followed our contribution guidelines and update the commit message and title of your Pull Request accordingly. Once you are ready, and all the checks pass, do let us know!'


is it possible to add the link to contribution guideline here?

Apparently they don't allow links as of now. We might have to proceed ahead with the link functionality for now.

Did you try with Markdown? i.e. [text](url)

0blivious · 2020-03-23T10:16:16Z

+          DAYS_BEFORE_CLOSE: 7
+          STALE_ISSUE_LABEL: 'stale'
+          STALE_PR_LABEL: 'stale'
+          STALE_PR_MESSAGE: 'Hi, were are going to mark this PR as stale because it has not had any updates for 30 days. If no further activity occurs within the following 7 days, it will be automatically closed so that others can take up the issue.If you are still working on this PR, please make a follow-up commit within 7 days and do leave a comment if you are still working on this PR. Please also let us know if you are stuck so we can help you!'


we are going to
inactivity for 30 days?
If you are still working on this PR, please make a follow-up commit within next 7 days and leave a comment to remove the stale label.

Tejas2805 · 2020-03-23T15:35:14Z

@damithc There is an update on this. The action also closes issues. And there is only one way to stop it rn. By using the exempt-issue-label tag. So we can just put all our labels in this and no issue will close. Is it okay to proceed with this? Or should we remove the action for now?

damithc · 2020-03-23T16:07:24Z

@damithc There is an update on this. The action also closes issues. And there is only one way to stop it rn. By using the exempt-issue-label tag. So we can just put all our labels in this and no issue will close. Is it okay to proceed with this? Or should we remove the action for now?

will that prevent PRs from closing too (if the same label is applied)?

Tejas2805 · 2020-03-23T17:54:02Z

will that prevent PRs from closing too (if the same label is applied)?

No, it won't. Only the issues.

UPDATE: Found another way to handle this. Shouldn't be a problem anymore

yong24s · 2020-03-25T12:24:15Z

The first-action has a flaw. It's only for people who are members of the organization and shows up for them only.

If it's not a limitation of GitHub's API, then we can fork and upgrade the project.

jamessspanggg · 2020-03-25T12:24:33Z

+     - name: stale
+       uses: gatsbyjs/stale@v1.1.0
+       with:
+          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}


Will this work for forked PRs as well?

Should work I believe. I have tried it on one of my repos from another account.

Do u mean this repo? It seems like the labelling is working, but the closing is not tho.

One of the PRs was created 5 days ago, but according to ur yml file, the closing is one day after the PR is marked as stale.

Tejas2805 · 2020-03-25T14:07:29Z

If it's not a limitation of GitHub's API, then we can fork and upgrade the project.

Don't think it a GitHub API limitation, since other actions provide the same feature.

I will look into it in another PR? Cause will take a bit of time to figure that out.

anubh-v · 2020-03-28T14:40:49Z

+on:
+  schedule:
+    # Runs at 00:00 every day
+    - cron: '0 0 * * *'


A clarification: does this check run every day?

Tejas2805 · 2020-03-30T09:24:28Z

This PR will take a bit of time. Creating own action based on our needs after forking.

Tejas2805 · 2020-03-31T12:55:00Z

Update: Have gotten it to work for labelling and closing PRs. If any suggestions on how to remove the label after a update, do let me know.

jamessspanggg · 2020-04-03T04:14:51Z

Update: Have gotten it to work for labelling and closing PRs. If any suggestions on how to remove the label after a update, do let me know.

Perhaps can look at this? https://developer.github.com/v3/issues/#update-an-issue

Tejas2805 · 2020-04-03T05:19:09Z

Perhaps can look at this? https://developer.github.com/v3/issues/#update-an-issue

Thanks! Looking into it.

Tejas2805 · 2020-04-23T09:41:50Z

The update for removing the label is on its way. Shall we wait or proceed for once? For the first 1/2 months, we might have to remove the labels manually but then shall get automated.

fzdy1914 · 2020-06-30T14:33:28Z

Hi, Can I know the status of this PR? the change part seems to be weird?

Tejas2805 · 2020-07-09T15:23:08Z

Continued in PR #1299

Tejas2805 added 2 commits March 20, 2020 05:08

add actions for stale PRs

350257d

add action for first-interaction

12c14c7

Tejas2805 closed this Mar 20, 2020

Tejas2805 reopened this Mar 20, 2020

Tejas2805 changed the title ~~Set up GitHub Actions~~ [#1166] Set up GitHub Actions Mar 20, 2020

Update first-interaction.yml

fd4c1b2

Tejas2805 marked this pull request as ready for review March 20, 2020 09:54

Merge branch 'master' into github-actions

5b2d229

damithc reviewed Mar 20, 2020

View reviewed changes

Comment thread .github/workflows/first-interaction.yml Outdated

Comment thread .github/workflows/first-interaction.yml Outdated

Comment thread .github/workflows/stale.yml Outdated

Tejas2805 added 3 commits March 22, 2020 06:23

Merge branch 'master' into github-actions

98ab2fe

Update first-interaction.yml

b85c2b7

Update stale.yml

f256a8d

damithc approved these changes Mar 22, 2020

View reviewed changes

jamessspanggg mentioned this pull request Mar 22, 2020

Travis fails with macOS 10.13.6 JDK8 #1174

Closed

Tejas2805 closed this Mar 22, 2020

Tejas2805 reopened this Mar 22, 2020

Tejas2805 requested a review from a team March 22, 2020 11:54

Tejas2805 closed this Mar 23, 2020

Tejas2805 reopened this Mar 23, 2020

0blivious reviewed Mar 23, 2020

View reviewed changes

Merge branch 'master' into github-actions

2afa59d

Tejas2805 added 2 commits March 24, 2020 07:31

Update stale.yml

88c9279

Update first-interaction.yml

550a4b7

Tejas2805 requested review from a team and 0blivious March 23, 2020 23:33

Tejas2805 added 3 commits March 25, 2020 05:56

Update stale.yml

87e635c

Merge branch 'master' into github-actions

9a47fa8

Delete first-interaction.yml

ca7d780

Tejas2805 requested a review from yong24s March 25, 2020 09:49

remove trailing spaces

fb3679b

yong24s approved these changes Mar 25, 2020

View reviewed changes

jamessspanggg reviewed Mar 25, 2020

View reviewed changes

0blivious approved these changes Mar 27, 2020

View reviewed changes

anubh-v reviewed Mar 28, 2020

View reviewed changes

Merge branch 'master' into github-actions

dcfb3df

Tejas2805 added the s.OnHold label Mar 30, 2020

Merge branch 'master' into github-actions

0e6dd45

Merge branch 'master' into github-actions

3403790

Tejas2805 added 2 commits April 4, 2020 07:16

Merge branch 'master' into github-actions

2dec837

Merge branch 'master' into github-actions

8073e84

Tejas2805 and others added 4 commits May 18, 2020 03:50

Merge branch 'master' into github-actions

32a8885

Merge branch 'master' into github-actions

397233b

Merge branch 'master' into github-actions

7a5b237

update action

e01b61c

Merge branch 'master' into github-actions

c133914

Tejas2805 closed this Jul 9, 2020

Conversation

Tejas2805 commented Mar 19, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Tejas2805 commented Mar 20, 2020

Uh oh!

damithc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

0blivious Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

Tejas2805 Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

Tejas2805 Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

yong24s Mar 24, 2020

Choose a reason for hiding this comment

Uh oh!

0blivious Mar 23, 2020

Choose a reason for hiding this comment

Uh oh!

Tejas2805 commented Mar 23, 2020

Uh oh!

damithc commented Mar 23, 2020

Uh oh!

Tejas2805 commented Mar 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yong24s commented Mar 25, 2020

Uh oh!

jamessspanggg Mar 25, 2020

Choose a reason for hiding this comment

Uh oh!

Tejas2805 Mar 25, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jamessspanggg Mar 28, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Tejas2805 commented Mar 25, 2020

Uh oh!

anubh-v Mar 28, 2020

Choose a reason for hiding this comment

Uh oh!

Tejas2805 commented Mar 30, 2020

Uh oh!

Tejas2805 commented Mar 31, 2020

Uh oh!

jamessspanggg commented Apr 3, 2020

Uh oh!

Tejas2805 commented Apr 3, 2020

Uh oh!

Tejas2805 commented Apr 23, 2020

Uh oh!

fzdy1914 commented Jun 30, 2020

Uh oh!

Tejas2805 commented Jul 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Tejas2805 commented Mar 19, 2020 •

edited

Loading

Tejas2805 commented Mar 23, 2020 •

edited

Loading

Tejas2805 Mar 25, 2020 •

edited

Loading

jamessspanggg Mar 28, 2020 •

edited

Loading