Update Makefile versions#3722
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 53652c2. Configure here.
| github.com/hashicorp/go-retryablehttp v0.7.8 | ||
| github.com/jedib0t/go-pretty/v6 v6.7.10 | ||
| github.com/k0sproject/k0s v1.34.7-0.20260329152645-c7811cd2c032 | ||
| github.com/k0sproject/k0s v1.34.8-0.20260511082531-a0cb5b2448a7 |
There was a problem hiding this comment.
K8s staging repo replace directives not updated with k0s
Medium Severity
The k0s dependency was upgraded to v1.34.8-0.20260511082531-a0cb5b2448a7 and the require sections bumped k8s.io/* staging repos to v0.34.7, but the replace directives in both go.mod (lines 79–109) and kinds/go.mod (lines 160–190) still pin all staging repos to v0.34.4. The comments on those blocks explicitly say "Keep in sync with k0s go.mod when upgrading k0s." Since replace overrides require, the actual resolved version is v0.34.4 — not the v0.34.7 that the updated k0s likely expects — which could cause subtle version mismatches or missing bug fixes at runtime.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 53652c2. Configure here.
replicated-ci-ec
force-pushed
the
automation/update-makefile
branch
from
53652c2 to
d8e8efc
Compare
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
2 participants
Automated changes by the cron-makefile-dependencies GitHub action