chore: remove dead v3 prototype code#3700
Draft
kriscoleman wants to merge 1 commit into
Draft
Conversation
Member
Author
|
will definitely need 👀 on this one |
The v3 prototype has been abandoned and moved to a separate repository. This cleanup removes all dead v3-specific code, environment variable gates (ENABLE_V3), and v3-only features from the v2 production codebase. Deleted files: - cmd/installer/cli/install_v3.go and tests - cmd/installer/cli/headless/install/* (entire directory) - tests/dryrun/v3_*_test.go (4 files) - .github/workflows/v3-e2e.yaml - e2e/kots-release-install-v3/* and upgrade-v3/* - e2e/licenses/ci-v3.yaml - pkg-new/k0s/mock.go, pkg-new/upgrade/mock.go Key changes: - Remove ENABLE_V3 env var gates from install, upgrade, version commands - Simplify KotsadmNamespace to always return 'kotsadm' - Simplify EmbeddedClusterLogsPath to use static v2 path - Remove headless install orchestrator and v3 install flow - Remove dead code from pkg-new/* packages - Update Makefile to always use v2 release directories - Update tests to match v2-only behavior
kriscoleman
force-pushed
the
cleanup/remove-dead-v3-code
branch
from
af4f31c to
df0e50e
Compare
|
This PR has been released (on staging) and is available for download with a embedded-cluster-smoke-test-staging-app license ID. Online Installer: Airgap Installer (may take a few minutes before the airgap bundle is built): Happy debugging! |
Member
Author
|
handing this off to @emosbaugh, they asked if they could steward it. Thanks Ethan! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The v3 prototype has been abandoned and moved to a separate repository. This PR removes all dead v3-specific code, environment variable gates (
ENABLE_V3), and v3-only features from the v2 production codebase.What was removed
Files deleted
cmd/installer/cli/install_v3.goandinstall_v3_test.gocmd/installer/cli/headless/install/*(entire directory: orchestrator, errors, mock client)tests/dryrun/v3_install_test.go,v3_upgrade_test.go,v3_install_preflights_test.go,v3_install_httpproxy_test.go.github/workflows/v3-e2e.yamle2e/kots-release-install-v3/*ande2e/kots-release-upgrade-v3/*e2e/licenses/ci-v3.yamlpkg-new/k0s/mock.go,pkg-new/upgrade/mock.goCode changes
ENABLE_V3env var gates from install, upgrade, version commands, and flag setupKotsadmNamespaceto always return"kotsadm"(no v3 dynamic namespace)EmbeddedClusterLogsPathto use static v2 path (/var/log/embedded-cluster)runManagerExperienceInstall,buildAPIOptions,validateHeadlessInstallFlags)isV3Enabled()fromflags.go;usesTargetFlagMenualways returnsfalserunVersionV3and helper functions fromversion.gopkg-new/*packages (unusedWithLogger,WithHTTPClient,PrintTable,RunAppPreflights,EnvSetter, etc.)Makefileto always use v2 release directories (removedENABLE_V3conditional)InstallHeadless,E2eRunHeadless,collectSupportBundles,printResults,formatCheckResultENABLE_V3)What was preserved
pkg-new/directory as a whole — v2 actively uses many of its subpackages (preflights,hostutils,cloudutils,validation, etc.)runManagerExperienceUpgradeinupgrade.go— used by v2 for kURL migrationVerification
go build ./...✅go vet ./cmd/... ./api/... ./pkg/...✅go test ./cmd/installer/cli/...✅go test ./api/internal/managers/app/...✅go test ./pkg/runtimeconfig/...✅go test ./pkg/addons/adminconsole/...✅go test -c ./tests/dryrun/...✅ (compile)