fix: honor enableInjected/enableEIP6963 and dedupe injected wallets#5655
Merged
Conversation
Wires `enableInjected` through to OptionsController state, splits the WagmiAdapter filter so `enableInjected` and `enableEIP6963` work independently, always dedupes featured/recommended against connectors, and applies `includeWalletIds`/`excludeWalletIds` to injected and EIP6963 connectors in the connect view. Closes #4430
🦋 Changeset detectedLatest commit: a555bf7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
9 Skipped Deployments
|
Contributor
Visual Regression Test Results ✅ PassedChromatic Build: https://www.chromatic.com/build?appId=6493191bf4b10fed8ca7353f&number=902 👉 Please review the visual changes in Chromatic and accept or reject them. |
Contributor
Contributor
📦 Bundle Size Check✅ All bundles are within size limits 📊 View detailed bundle sizes> @reown/appkit-monorepo@1.7.1 size /home/runner/work/appkit/appkit > size-limit |
Contributor
3 tasks
enesozturk
added a commit
that referenced
this pull request
May 6, 2026
…on test The mobile-wallet-features.spec.ts:73 "it should show open button" test asserts the secondary button is disabled immediately after clicking a wallet, then enabled 2s later — but w3m-connecting-wc-mobile sets isLoading = !this.uri synchronously in its constructor. When the WC URI is already cached (depends on relay timing and prior tests in the serial suite), the loading state is invisible and the disabled assertion fails. Same widget pattern exists for the desktop equivalent (w3m-connecting-wc-web) but the desktop test never asserts on loading state, so only the mobile test is affected. Drop the disabled: true precondition. The remaining disabled: false assertion (with 60s default timeout) verifies what users actually care about — the Open button works after picking a wallet. This flake has been blocking unrelated PRs (e.g. #5655 on April 30, #5638). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes wallet filtering options on the Wagmi adapter so they actually behave as documented.
enableInjectedwas never wired toOptionsControllerstate, the wagmiaddWagmiConnectorfilter conflated the basic injected connector with EIP6963-discovered ones, andWalletUtil.filterOutDuplicatesByRDNSskipped dedup wheneverenableEIP6963was false — which is why MetaMask appeared twice.includeWalletIdsandexcludeWalletIdspreviously only filtered API-fetched wallets; they now also filter injected/EIP6963/multi-chain connectors in the connect view viaconnector.explorerId/connector.explorerWallet?.id. Verified with 7 new unit tests across@reown/appkit-controllers,@reown/appkit-adapter-wagmi, and@reown/appkit-scaffold-ui, all of which fail against the unfixed source and pass with the fix applied.Type of change
Associated Issues
Closes #4430
Showcase (Optional)
N/A — no UI visual changes; behavior change is in which wallets render.
Checklist