Added RCS propellants to propellant library and made migration function#271
Open
mihirshevade wants to merge 1 commit into
Open
Added RCS propellants to propellant library and made migration function#271mihirshevade wants to merge 1 commit into
mihirshevade wants to merge 1 commit into
Conversation
|
@mihirshevade nice work! |
reilleya
requested changes
Jun 15, 2026
| } | ||
|
|
||
| DEFAULT_PROPELLANTS = [CL_PROPS, OW_PROPS, KNDX_PROPS, KNSB_PROPS, KNSU_PROPS, WL_PROPS, BT_PROPS] | ||
| CL_PROPS = { |
Owner
There was a problem hiding this comment.
Looks like this is a duplicate of the other CL definition above?
| ] | ||
| } | ||
|
|
||
| WL_PROPS = { |
| ] | ||
| } | ||
|
|
||
| BT_PROPS = { |
| 'minPressure': 0, | ||
| 'maxPressure': 10342500, | ||
| 'a': 0.00002969528, | ||
| 'n': 0.36600000, |
Owner
There was a problem hiding this comment.
I think this is the N for Redline?
| 'minPressure': 0, | ||
| 'maxPressure': 10342500, | ||
| 'a': 1.23560472e-03, | ||
| 'n': 0.056, |
Owner
There was a problem hiding this comment.
...and this is the one for Black Jack?
| 'minPressure': 0, | ||
| 'maxPressure': 10342500, | ||
| 'a': 1.23560472e-03, | ||
| 'n': 0.056, |
Owner
There was a problem hiding this comment.
This is the black jack one again, Black Max is actually 0.398 according to RCS
| 'minPressure': 0, | ||
| 'maxPressure': 10342500, | ||
| 'a': 0.00001507051, | ||
| 'n': 0.398, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added propellant data for all AeroTech propellants from the RCS website and created a migration function to add the new propellants to users' libraries when upgrading from 0.6.1 to 0.6.2