Repository navigation
DOC-7186: reinstate the image shortcode temporarily for older open PRs - #4267
Merged
Merged
Conversation
#4207 (DOC-7128) retired the image shortcode after every image on main had been converted to Markdown. Older open PRs that still contain {{< image >}} calls then failed the build ("template for shortcode "image" not found") until each was converted, which is causing friction. This restores the shortcode exactly as it was, so those PRs build again, until it can be retired a second time. layouts/shortcodes/image.html and layouts/partials/process-markdown-content.html are restored byte-for-byte to their pre-#4207 versions (71d877f^). The partial's two image-shortcode rules have to come back as well, or a shortcode in an old PR would reach the AI Markdown/JSON feed as raw shortcode text. Nothing else from #4207 is reverted: the five deleted embeds were unused, and the README keeps teaching Markdown images, which all new content should use. Tested with a temporary page using the shortcode forms old PRs contain (plain, widthed with a bare path and unquoted width, an inline #no-click icon, and a screenshot in a list step), built under the production baseURL. The build passes, all four render the pre-#4207 markup with the /docs/latest/ prefix, and the feed turns each into an absolute Markdown image. main has no shortcode calls, so its own rendering doesn't change. Directive: before re-retiring the shortcode, scan open PRs for {{< image (not just main), or this happens again Ticket: DOC-7186 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at cdff194 |
Contributor
Author
|
Thanks @mich-elle-luna ! |
EliShteinman
added a commit
to EliShteinman/docs
that referenced
this pull request
Oct 15, 2026
Reinstate the image shortcode temporarily so older open PRs that still use it keep building. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
EliShteinman
added a commit
to EliShteinman/docs
that referenced
this pull request
Oct 15, 2026
… placeholder Upstream redis#4267 brought back the image shortcode regexes with a hardcoded redis.io URL; restore the __DOCS_BASE_URL__ form they had before redis#4207. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings back the
imageshortcode, exactly as it was before #4207 retired it, so older open PRs that still use{{< image … >}}build again. Since #4207, those PRs fail withtemplate for shortcode "image" not founduntil each one is converted, and that's been causing friction. We can retire the shortcode a second time once the older PRs have been dealt with. DOC-7186Restored, byte-for-byte from just before #4207 (
71d877f82^):layouts/shortcodes/image.htmllayouts/partials/process-markdown-content.html, which brings back the two rules that rewrite image shortcodes for the AI Markdown/JSON feed. Without them, a shortcode in an old PR would reach the feed as raw shortcode text. Nothing else has touched this file since DOC-7128: retire the image shortcode #4207.Not reverted: the five embeds #4207 deleted (nothing used them), and the README's Images section, which keeps teaching Markdown. New content should still use Markdown images, as all of
mainalready does.Verification
#no-clickicon, and a screenshot inside a list step. The build passes, all four render the pre-DOC-7128: retire the image shortcode #4207 markup (<a sdata-lightbox>wrapper,width/classpassed through, correct/docs/latest/prefix), and the AI feed turns each into an absolute Markdown image.mainhas no shortcode calls, so its own rendering doesn't change.Before re-retiring: scan open PRs for
{{< image, not justmain, so this doesn't happen again.🤖 Generated with Claude Code
Note
Low Risk
Temporary template and feed-rewrite restore for deprecated syntax; no change to current main content or auth/data paths.
Overview
Temporarily reinstates the Hugo
imageshortcode removed in #4207 so branches that still use{{< image filename="…" >}}build instead of failing with a missing template.Adds back
layouts/shortcodes/image.html(lightbox-linked<img>with optional width/align/alt/class). Inprocess-markdown-content.html, restores AI/Markdown feed rewriting that turnsimageshortcodes—literal or HTML-escaped—into absolutelinks, while keeping the existing Markdown-image cleanup and path absolutization (DOC-7128).mainbehavior is unchanged (no shortcode usage); this is a compatibility bridge until older PRs are migrated to Markdown images.Reviewed by Cursor Bugbot for commit cdff194. Bugbot is set up for automated code reviews on this repo. Configure here.