DOC-7103 Document SNI hostname precedence for StackExchange.Redis TLS/cluster connections - #4082
Merged
Merged
Conversation
…/cluster connections Adds an "SNI hostname selection for cluster connections" subsection to connect.md's TLS section, covering the SslHost/DnsEndPoint/default-provider/ endpoint-address precedence StackExchange.#3250 introduced. Verified this is real, shipped behavior rather than an in-flight PR: `gh api repos/StackExchange/StackExchange.Redis/compare/3.3.1...<merge_commit_sha>` returned "identical", meaning the merge commit for #3250 *is* the 3.3.1 tag commit, not just an ancestor of it. That's a stronger and cheap-to-run check than eyeballing "merged" + a changelog mention, and it's why the version gate here is pinned to exactly v3.3.1, not "3.3.x" or "check the changelog." Left the fallback provider unnamed ("the default SNI provider") rather than citing the internal `GetSslHostFromEndpoints` method the upstream PR description uses — couldn't confirm it's stable public API rather than an implementation detail, and AGENTS.md's prose/code-form split only calls for literal identifiers where the reader actually types them. Learned: gh compare(tag...merge_sha) == identical is a reliable released-vs-merged check, cheaper than changelog reading Rejected: naming GetSslHostFromEndpoints in prose | not confirmed as stable public API, only appears in the upstream PR description Constraint: version gate must stay exactly v3.3.1 (the tag the merge commit resolves to), not loosened to "3.3.x" Recheck: if StackExchange.Redis changes SslHost/SNI resolution again, re-verify this precedence order and version gate against the new release Ticket: DOC-7103 Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
Contributor
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at b9883b0 |
Contributor
Author
|
Thanks @dwdougherty ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
3.3.1tag commit (verified viagh api .../compare/3.3.1...<merge_sha>returningidentical), so the version gate is pinned to exactly v3.3.1./pr-scan-review; ticket DOC-7103.Test plan
content/develop/clients/dotnet/connect.md🤖 Generated with Claude Code
Note
Low Risk
Documentation-only change to the .NET client connect guide with no runtime or security behavior changes.
Overview
Adds documentation under the .NET Connect to your production Redis with TLS section explaining how StackExchange.Redis picks the TLS SNI hostname when cluster nodes are discovered via
CLUSTER SLOTS, so load balancers/proxies can route handshakes correctly.The new subsection documents a v3.3.1+ precedence order (
SslHost→DnsEndPointhost → default SNI provider → endpoint address) and clarifies thatConfigurationOptions.SslHostis only surfaced when set explicitly, not when inferred by the client.Reviewed by Cursor Bugbot for commit b9883b0. Bugbot is set up for automated code reviews on this repo. Configure here.