Skip to content

Correct RESP "bulk" categorization - #4051

Merged
dwdougherty merged 1 commit into
redis:mainfrom
mgravell:patch-2
Sep 29, 2026
Merged

dwdougherty merged 1 commit into
redis:mainfrom
mgravell:patch-2

Conversation

@mgravell

@mgravell mgravell commented Sep 18, 2026 •

Copy link
Copy Markdown
Collaborator

Multiple length-prefixed scalar types are incorrectly categorized as "aggregate" rather than "bulk"


Note

Low Risk
Documentation-only table correction with no runtime or API impact.

Overview
Corrects the RESP data-type summary table so length-prefixed scalar encodings are labeled Bulk instead of Aggregate.

The Category column now shows Bulk for bulk strings, null bulk strings, bulk errors, and verbatim strings. Arrays, maps, sets, attributes, and pushes remain Aggregate, matching the doc’s simple / bulk / aggregate taxonomy.

Reviewed by Cursor Bugbot for commit 24db21d. Bugbot is set up for automated code reviews on this repo. Configure here.

Multiple length-prefixed scalar types are incorrectly categorized as "aggregate" rather than "bulk"
@CLAassistant

CLAassistant commented Sep 18, 2026 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@dwdougherty dwdougherty left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mgravell. Thank you for this; much appreciated! I'll go ahead and approve, but I do have one comment (from Claude, actually):

One loose end I [Claude] did not touch since it's outside the diff: line 786 of the same page uses "aggregate" informally ("Reading the length of aggregate types (for example, bulk strings or arrays)...") in a way that conflicts with the formal taxonomy the PR is enforcing. That's a pre-existing wording quirk on the page, unrelated to this PR's table fix — worth a separate look if you want the page fully self-consistent, but it's not something this PR needs to address.

Please sign the CLA; otherwise, I cannot merge your work.

@dwdougherty dwdougherty self-assigned this Sep 18, 2026
@dwdougherty

Copy link
Copy Markdown
Collaborator

Hi @mgravell. Just another reminder that you need to sign the CLA so I can merge this PR.

@dwdougherty
dwdougherty merged commit 1bf86d9 into redis:main Sep 29, 2026
4 of 5 checks passed
EliShteinman added a commit to EliShteinman/docs that referenced this pull request Sep 29, 2026
Recategorizes bulk strings, null bulk strings, bulk errors and verbatim strings as Bulk in the RESP type table.
@mgravell

Copy link
Copy Markdown
Collaborator Author

Sorry, didn't see the notification and was OOO. On CLA: happy to do that post-hoc, but note I'm also staff, so: it is somewhat implied by contract :)

@mgravell

Copy link
Copy Markdown
Collaborator Author

(signed; for info, the CLA bot was a hot mess and needed about 7 attempts to succeed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants