Fix --relatives bug to generate distinct org_ids per relative#172
Open
hyp3rion31gr3y wants to merge 1 commit into
Open
Fix --relatives bug to generate distinct org_ids per relative#172hyp3rion31gr3y wants to merge 1 commit into
hyp3rion31gr3y wants to merge 1 commit into
Conversation
The _get_relatives() method was incorrectly creating the same org_id for all relatives by calling self._get_account() once outside the loop and reusing the value. This caused all hosts to be associated with the same organization regardless of the --relatives parameter value. Fixed by moving self._get_account() calls inside the list comprehension so each relative gets a unique org_id, enabling proper multi-tenant performance testing scenarios. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
jhutar
reviewed
Jun 17, 2026
| { | ||
| "account": common_acc_orgid, | ||
| "orgid": common_acc_orgid, | ||
| "account": self._get_account(), |
Contributor
There was a problem hiding this comment.
This way "account" and "orgid" will be different. I do not see a problem with current code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The _get_relatives() method was incorrectly creating the same org_id for all relatives by calling self._get_account() once outside the loop and reusing the value. This caused all hosts to be associated with the same organization regardless of the --relatives parameter value.
Fixed by moving self._get_account() calls inside the list comprehension so each relative gets a unique org_id, enabling proper multi-tenant performance testing scenarios.