Skip to content

test(version-management): add e2e integration tests for plugin check-versions and upgrade #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gashcrumb merged 5 commits into from
Oct 7, 2026
Merged

test(version-management): add e2e integration tests for plugin check-versions and upgrade #231

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c671f10
test(version-management): add e2e integration tests for plugin check-…
gashcrumb Oct 2, 2026
9ce0e86
test(e2e): deduplicate runExpectingFailure helper in support/plugin-e…
gashcrumb Oct 2, 2026
c442487
fix(upgrade): allow lockfile mutation during install in CI environments
gashcrumb Oct 2, 2026
3a3652f
test(version-management): address review feedback on e2e test suite
gashcrumb Oct 5, 2026
d350eee
test(version-management): address reviewer feedback on e2e test suite
gashcrumb Oct 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 1 addition & 35 deletions e2e-tests/plugin-dev.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
log,
logSection,
runCommand,
RunCommandOptions,
runExpectingFailure,
} from './support/plugin-export-build';
Comment thread
gashcrumb marked this conversation as resolved.
import {
cleanupCompose,
Expand All @@ -33,40 +33,6 @@ const availableTools = detectAvailableComposeToolsSync();
const describeWithCompose =
availableTools.length > 0 ? describe : describe.skip;

async function runExpectingFailure(
command: string,
options: RunCommandOptions = {},
): Promise<{ stdout: string; stderr: string; message: string }> {
let succeeded = false;
let stdout = '';
let caughtError: unknown;

try {
const res = await runCommand(command, options);
succeeded = true;
stdout = res.stdout;
} catch (err: unknown) {
caughtError = err;
}

if (succeeded) {
throw new Error(
`Command expected to fail, but succeeded with output: ${stdout}`,
);
}

const e = (caughtError || {}) as {
stdout?: string;
stderr?: string;
message?: string;
};
return {
stdout: e?.stdout || '',
stderr: e?.stderr || '',
message: e?.message || '',
};
}

describe('plugin dev', () => {
const tmpDir = fs.mkdtempSync(path.join(os.tmpdir(), 'rhdh-cli-plugin-dev-'));
const pluginDir = path.join(tmpDir, 'test-frontend-plugin');
Expand Down
Loading
Loading