Add persistent volume sizes in Artifactory and Instructions to Readme

[smatula]

Summary by CodeRabbit

• Documentation

  • Added a guide for resizing PVCs via GitOps (note: the guide appears twice in the README).

• New Features

  • Added persistent storage for Artifactory (500 GiB) and PostgreSQL (200 GiB) and registered the PVCs with the deployment manifests.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Adds duplicated README guidance for resizing PVCs for GitOps-managed StatefulSets; introduces PVC resources and persistence settings for Artifactory and its PostgreSQL in the Artifactory component, specifying 500Gi and 200Gi sizes and including the PVC manifest in kustomization.

Changes

Cohort / File(s)	Summary
Documentation README.md	Inserts a new section describing step-by-step PVC resize for StatefulSets under GitOps (update Git, delete StatefulSet with cascade=orphan, patch PVC, force sync). Note: the block appears twice.
Artifactory values components/artifactory/values.yaml	Adds persistence blocks enabling existingClaim references for Artifactory and PostgreSQL primary with sizes specified in accompanying PVCs.
Kustomization components/artifactory/kustomization.yaml	Adds pvc.yaml to the kustomization resources list.
PersistentVolumeClaims components/artifactory/pvc.yaml	Adds two PVC manifests: artifactory-volume-jfrog-container-registry-artifactory-0 (500Gi) and data-jfrog-container-registry-postgresql-0 (200Gi), both in namespace artifactory.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20–30 minutes

• Review duplication in README.md and remove or consolidate if unintentional.
• Verify that components/artifactory/values.yaml persistence blocks are correctly nested and reference the exact PVC names.
• Confirm PVC sizes and access modes match cluster storage class capabilities and capacity planning.
• Ensure components/artifactory/kustomization.yaml ordering and resource references do not conflict with existing overlays.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main changes: adding persistent volume sizes for Artifactory and documentation instructions in README.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 950a5c4 and ab490c0.

📒 Files selected for processing (2)

• README.md (1 hunks)
• components/artifactory/values.yaml (2 hunks)

🧰 Additional context used

🪛 LanguageTool

README.md

[style] ~239-~239: To form a complete sentence, be sure to include a subject.
Context: ...VC" action 4. Force Sync to reconcile. Should be successful. ## Development ### Add...

(MISSING_IT_THERE)

🔇 Additional comments (2)

components/artifactory/values.yaml (2)

9-11: The persistence configuration at lines 9–11 and the PostgreSQL persistence at lines 37–39 correctly align with the Artifactory Helm chart structure. Both paths and configurations are valid and properly nested under the artifactory root key. No changes needed.

---

37-39: PostgreSQL persistence configuration is correctly structured.

The configuration at lines 37-39 properly enables PostgreSQL primary persistence with a 200Gi allocation. The path is postgresql.primary.persistence (not artifactory.postgresql.primary.persistence). This follows the standard Bitnami PostgreSQL Helm chart pattern and the sizing is appropriate for an Artifactory database.

[coderabbitai]

Actionable comments posted: 0

♻️ Duplicate comments (1)

README.md (1)

239-239: Incomplete sentence flagged in previous review.

Line 239 has a grammatical issue: "Sync should be successful" is the corrected version (adding "Sync" as the subject).

🧹 Nitpick comments (1)

components/artifactory/pvc.yaml (1)

24-25: Consider removing the trailing document separator.

The trailing --- on line 24 followed by an empty line is unnecessary since there's no additional YAML document. While not incorrect, removing it improves file cleanliness.

Apply this diff to clean up the file:

       storage: 200Gi
----
-

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ab490c0 and 0b44af9.

📒 Files selected for processing (4)

• README.md (1 hunks)
• components/artifactory/kustomization.yaml (1 hunks)
• components/artifactory/pvc.yaml (1 hunks)
• components/artifactory/values.yaml (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• components/artifactory/values.yaml

🔇 Additional comments (3)

components/artifactory/kustomization.yaml (1)

7-7: LGTM!

The addition of pvc.yaml to the resources correctly integrates the new PersistentVolumeClaim definitions into the Kustomization.

README.md (1)

219-240: No duplication found in this README section.

The search for "Increase PVC size when App uses StatefulSets" returns only a single occurrence at line 219, and distinctive patterns like "cascade=orphan" appear only within that one section. This documentation section is not duplicated in the README.

Likely an incorrect or invalid review comment.

components/artifactory/pvc.yaml (1)

1-23: Verify that the cluster has a default StorageClass configured.

No storageClassName is specified for either PVC, which means they will use the cluster's default StorageClass. Ensure that a default StorageClass exists and supports dynamic provisioning with the required capacity (500Gi and 200Gi).

Run the following script to check for a default StorageClass:

#!/bin/bash
# Description: Check if a default StorageClass is configured in the cluster

# Get the default StorageClass
kubectl get storageclass -o jsonpath='{.items[?(@.metadata.annotations.storageclass\.kubernetes\.io/is-default-class=="true")].metadata.name}'

# List all StorageClasses with their provisioners and settings
echo -e "\n\nAll StorageClasses:"
kubectl get storageclass -o custom-columns=NAME:.metadata.name,PROVISIONER:.provisioner,RECLAIM:.reclaimPolicy,VOLUMEBINDING:.volumeBindingMode,ALLOWEXPANSION:.allowVolumeExpansion