Change repo name to rhads-services-gitops

[smatula]

Summary by CodeRabbit

• Chores
  • Updated repository references across deployment manifests and cluster configurations.
  • Enhanced deployment automation with improved synchronization policies, resource pruning capabilities, namespace management, and infrastructure domain configuration updates.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

This PR performs a systematic rename across the repository, replacing "rhtap" references with "rhads" in application metadata, repository URLs, domain configurations, and inline documentation. Changes include Application/ApplicationSet name updates, GitOps repository URL migrations, infrastructure domain changes, and syncPolicy enhancements to the primary app-of-apps configuration.

Changes

Cohort / File(s)	Summary
Documentation & Configuration README.md, envfile	Updated title and inline comment label from "rhtap" to "rhads" reference.
Core App-of-Apps Configuration app-of-apps.yaml	Updated Application name from rhtap-services-app-of-apps to rhads-services-app-of-apps, changed repoURL accordingly, and enhanced syncPolicy with prune: true, selfHeal: true, and new syncOptions (CreateNamespace=true, PruneLast=true).
Individual App-of-Apps Applications app-of-apps/acs.yaml, app-of-apps/jenkins.yaml, app-of-apps/jfrog-artifactory-jcr.yaml, app-of-apps/multicluster-engine.yaml, app-of-apps/nexus.yaml, app-of-apps/tpa.yaml	Updated source repoURL references from https://github.com/redhat-appstudio/rhtap-services-gitops to https://github.com/redhat-appstudio/rhads-services-gitops (single or multiple occurrences per file).
Infrastructure Domain Configuration components/multicluster-engine/clusterPool.yaml, components/multicluster-engine/hiveconfig.yaml	Updated baseDomain and managedDomains entries from rhtap.devcluster.openshift.com to rhads.devcluster.openshift.com.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

• Verify that the new syncPolicy settings (prune: true, selfHeal: true, CreateNamespace=true, PruneLast=true) in app-of-apps.yaml align with intended cluster behavior and do not cause unintended cascading deletions or namespace creation conflicts
• Confirm all repository URL transitions are consistent across all application definitions
• Validate that infrastructure domain changes in clusterPool and hiveconfig align with actual cluster provisioning setup

Possibly related PRs

• Update TPA to use application set and cluster generator #13: Both PRs modify app-of-apps/tpa.yaml; this PR updates the repoURL/name while the related PR introduces ApplicationSet templating with dynamic sources.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Change repo name to rhads-services-gitops' directly and accurately summarizes the main objective of the pull request, which is to rename the repository references throughout the codebase from 'rhtap-services' to 'rhads-services'.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 950a5c4 and eceefb8.

📒 Files selected for processing (11)

• README.md (1 hunks)
• app-of-apps.yaml (2 hunks)
• app-of-apps/acs.yaml (1 hunks)
• app-of-apps/jenkins.yaml (2 hunks)
• app-of-apps/jfrog-artifactory-jcr.yaml (2 hunks)
• app-of-apps/multicluster-engine.yaml (1 hunks)
• app-of-apps/nexus.yaml (1 hunks)
• app-of-apps/tpa.yaml (1 hunks)
• components/multicluster-engine/clusterPool.yaml (1 hunks)
• components/multicluster-engine/hiveconfig.yaml (1 hunks)
• envfile (1 hunks)

🔇 Additional comments (11)

components/multicluster-engine/hiveconfig.yaml (1)

17-17: Domain rename looks correct.

The domain update from rhtap.devcluster.openshift.com to rhads.devcluster.openshift.com aligns with the repository rename. Ensure the new domain is properly configured in AWS Route53 with the appropriate hosted zone and delegation before deploying.

README.md (1)

1-1: README title updated correctly.

The title change aligns with the repository rename.

components/multicluster-engine/clusterPool.yaml (1)

9-9: Base domain update is consistent with HiveConfig.

The baseDomain change correctly matches the updated managedDomains in hiveconfig.yaml, ensuring cluster provisioning will use the correct domain.

app-of-apps/tpa.yaml (1)

24-24: Repository URL update is consistent.

The repoURL change aligns with the repository rename across all app-of-apps manifests.

app-of-apps/acs.yaml (1)

12-12: Repository URL update is consistent.

The change aligns with the repository rename.

envfile (1)

7-7: Comment update is consistent with the rename.

Non-functional change that keeps documentation aligned with the new repository name.

app-of-apps.yaml (3)

4-4: Application name updated consistently with repository rename.

The application name change from rhtap-services-app-of-apps to rhads-services-app-of-apps is consistent with the repository rename objective.

---

17-21: Good addition: syncPolicy enhancements align with other application manifests.

The addition of prune: true, selfHeal: true, CreateNamespace=true, and PruneLast=true brings this app-of-apps configuration in line with the other application manifests in the repository.

---

13-13: Verify the new repository URL is accessible before merging.

The repository naming has been updated to align with the product rebranding from RHTAP to RHADS. Ensure the rhads-services-gitops repository has been created and is accessible on GitHub, and confirm that the infrastructure is in place before merging this PR.

app-of-apps/jenkins.yaml (1)

12-12: Repository URLs updated consistently.

Both GitOps repository URL references have been updated from rhtap-services-gitops.git to rhads-services-gitops.git, maintaining consistency with the repository rename.

Also applies to: 22-22

app-of-apps/jfrog-artifactory-jcr.yaml (1)

12-12: Repository URLs updated consistently.

Both source references have been updated from rhtap-services-gitops to rhads-services-gitops, aligning with the repository rename objective.

Also applies to: 22-22

[coderabbitai]

⚠️ Potential issue | 🔴 Critical

Verify the new repository exists before merging.

The repository rhads-services-gitops does not appear to exist on GitHub. This will cause Argo CD sync failures when the configuration is deployed. Either create the repository first or update the repoURL to point to an existing repository.

🤖 Prompt for AI Agents

In app-of-apps/nexus.yaml around line 13, the repoURL points to
https://github.com/redhat-appstudio/rhads-services-gitops which does not exist
and will cause Argo CD sync failures; either create the GitHub repository at
that URL or update repoURL to an existing repository URL, commit the change, and
verify access/credentials and that Argo CD can successfully sync the repo before
merging.

[rhopp]

TBH... I'm not sure about the change in multicluster-engine... The domain. But as that's something only I use for now, let's merge this PR as is...and if this breaks Hive, I'll deal with it tomorrow ;-)