Fix parsing + add invalid tags#24
Open
phil-flip wants to merge 2 commits into
Open
Conversation
Contributor
Author
|
I should also mention that I was not able to find the "gender" data-point anymore on FA. So i hardcoded it to "Other / Not Specified" for now. Might need to be sundowned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FA seemed to completely overhauled submission pages, breaking the parsing quite a lot.
I tried my best to fix them all. but I have not tested the package yet. (Only copied the edits from my temporary node_modules edits)
I noticed that FA now features "invalid tags" (CSS class: tag-invalid) which would be easier to parse data, as "submission-content-stats" doesn't have a good way of pinning the info. However, I discovered this quite late, when I was already done with the "old" method. Regardless I did add "keywordsInvalid" and add those tags, so you can decide if we should use these for future parsing of the data and/or include them with normal keywords.
Fixes: #23