fix(mdxish): inline Anchor/Glossary with expression attrs render as plain text#1525
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
WalkthroughThe MDX tokenizer ( Comment |
|
Merging because it was previously approved and it was just a merge conflict dismissing it. |
🎯 What does this PR do?
There was a reported bug where
<Anchor>tags were breaking not rendering as links. The root cause of the reported Anchor was it contained complex expression in an attribute:href={'https://' + user.docsUrl + '/reference/sign-up-api'}, which the raw anchor HTML can't render.The fix is to now let the mdx tokenizer to now claim inline PascalCase components in text mode (Anchor & Glossary) and pass it on the relatively newly created MDX inline HTML transformer path (processor/transform/mdxish/components/inline-html.ts), which parses them into
mdxJsxTextElementso they render correctly.🧪 QA tips
Inline
Anchorwith a concatenation-expressionhrefrenders as a link (the original repro):Inline
Glossarywith a template-literal expression attr renders:<Glossary term={`a${b}c`}>word</Glossary>Plain inline
Anchor(no expression attrs) still renders via the existing CommonMark path:📸 Screenshot or Loom
Old mdxish editor vs fixed mdxish vs legacy editor (correct baseline):
Screen.Recording.2026-06-25.at.4.28.51.pm.mov