Fix enrollment rollback desync, OAuth link race, and cache lock#113
Merged
Conversation
- User: assignEnrolledClassCode only issues the UPDATE; the in-memory enrolledClassCode is assigned after the transaction commits in enrollInClass/withdrawFromClass, so a rollback no longer leaves the object out of sync with the database (#27). - OAuthRoutes: upsert the existing-user auto-link against the (provider, providerId) unique index so concurrent first-login callbacks converge to one link/user instead of a duplicate-key exception. (The rarer new-user createOAuthUser race is left for the fuller transaction+email-lock fix.) (#28) - Challenge: functionInfo() uses double-checked get/putIfAbsent so the blocking network fetch + script eval no longer runs inside the ConcurrentHashMap bin lock (#29). Add tests: OAuth concurrent-callback convergence and functionInfo memoization. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three low-severity correctness/concurrency fixes.
User.assignEnrolledClassCodeonly issues the UPDATE; the in-memoryenrolledClassCodeis assigned after the transaction commits inenrollInClass/withdrawFromClass, so a rollback no longer leaves the object out of sync with the database.findOrCreateOAuthUserupserts the existing-user auto-link against the(provider, providerId)unique index, so concurrent first-login callbacks converge to one link/user instead of a duplicate-key exception. (The rarer new-usercreateOAuthUserrace is left for the fuller transaction+email-lock fix.)Challenge.functionInfo()uses double-checkedget/putIfAbsentso the blocking network fetch + script eval no longer runs inside theConcurrentHashMapbin lock.Tests
New
OAuthFindOrCreateRaceTest(20 concurrent callbacks → one link, verified RED against the oldinsert) andChallengeFunctionInfoMemoTest(memoization preserved). Full suite green; lint + detekt clean.🤖 Generated with Claude Code