Skip to content

feat: move away from Kindlegen to Kindling#2718

Merged
BoboTiG merged 1 commit into
mainfrom
feat-kindling
Jul 4, 2026
Merged

feat: move away from Kindlegen to Kindling#2718
BoboTiG merged 1 commit into
mainfrom
feat-kindling

Conversation

@BoboTiG

@BoboTiG BoboTiG commented Jun 25, 2026

Copy link
Copy Markdown
Member

All <br> tags are forced to <br/> in order to comply with Kindle XHTML requirements.

Closes #2670.


I open the PR for curiosity first. The code works, but there are many issues with Kindling, among them:

  1. Most of words do not work (like looking for "péri" that doesn't show up "périr" while this variant is part of the HTML file), and like 50-60% of words that are actually in the dictionary are not found by my Kindle.
  2. HTML is stripped, meaning we loose our beautiful lists, and space between POS.
  3. There are many warnings from the generated XHTML, I fixed a bunch already (81a343c, f97e892, a6459f0, 5d726f7) but we should try to fix most of them, e.g.:
[warning R6.10] section 6 (p.22): XHTML references a named entity that is not in the XML 1.0 predefined set or the common HTML5 whitelist. Undeclared entities render as literal text on Kindle. Entity: &thinsp; (g000865.xhtml)`

On the positive side:

  • The whole French dictionary is generated in 1 minute and 13 seconds (that's quite impressive!).
  • Quite an interesting code clean-up on our side.

Still need to check:

  • maximum variants count
  • languages support

That's not acceptable as-is, and I try from time to time with newer Kindling version to see if improvements arise.

Latest Kindling version tested is v0.19.1.

@BoboTiG

BoboTiG commented Jun 26, 2026

Copy link
Copy Markdown
Member Author

Update with v0.20.3: the primary problem (point 1) is now fixed ✔️

  • Point 2 is still important to consider before doing the move.
  • Point 3 is no blocker.

I'll test variants and languages support.

@BoboTiG

BoboTiG commented Jun 27, 2026

Copy link
Copy Markdown
Member Author

According the its creator (ciscoriordan/kindling#8 (comment)) there is no maximum variants limit, and any language will work. This is very good!

All `<br>` tags are forced to `<br/>` in order to comply with Kindle XHTML requirements.
@BoboTiG BoboTiG marked this pull request as ready for review July 4, 2026 09:51
@BoboTiG

BoboTiG commented Jul 4, 2026

Copy link
Copy Markdown
Member Author

Point 2 is fixed in v0.22.1. We are good to go!

@BoboTiG BoboTiG merged commit 28e261c into main Jul 4, 2026
1 check passed
@BoboTiG BoboTiG deleted the feat-kindling branch July 4, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: move away from kindlegen for Kindling

1 participant