Repository navigation

refactor: cross-layer cleanup and sink duplicated native logic into the shared C++ cores - #657

Merged

sunnylqm merged 109 commits into

masterfrom

claude/code-cleanup-refactor-dd7306

Oct 12, 2026

Merged

refactor: cross-layer cleanup and sink duplicated native logic into the shared C++ cores#657
sunnylqm merged 109 commits into
masterfrom
claude/code-cleanup-refactor-dd7306

Commits on Oct 12, 2026
- chore(lint): check C++ constant mirrors on Android and JS too
  
  sunnylqm
  and
  claude
  committed
  1532256
- fix(flow-core): drop Object.hasOwn, missing from JSC before iOS 15.4
  
  sunnylqm
  and
  claude
  committed
  0be289e
- refactor: single jsonDeepEqual in updateFlowCore
  
  sunnylqm
  and
  claude
  committed
  f8ce0f4
- refactor(error): derive UpdateErrorCode from one code list
  
  sunnylqm
  and
  claude
  committed
  57fdfec
- fix(harmony): stop retrying mirrors after a patch fails to apply
  
  sunnylqm
  and
  claude
  committed
  9bb13e0
- refactor(core): web-safe nativeMethod helper for optional native methods
  
  sunnylqm
  and
  claude
  committed
  2d2ffc2
- refactor(harmony): drop dead code and generated files
  
  sunnylqm
  and
  claude
  committed
  c66f83b
- refactor(client): trim endpoint plumbing
  
  sunnylqm
  and
  claude
  committed
  b2e561c
- build(android): drop pre-7.5 Gradle exec path, dedupe gradle and ndk flags
  
  sunnylqm
  and
  claude
  committed
  65e4c73
- fix(android-jni): build Java strings from UTF-8 with NewString, not NewStringUTF
  
  sunnylqm
  and
  claude
  committed
  1e139be
- refactor(client): one telemetry POST for events and exceptions
  
  sunnylqm
  and
  claude
  committed
  1de1fb7
- refactor(android-jni): dedupe manifest building and exception guards
  
  sunnylqm
  and
  claude
  committed
  0f87872
- refactor(client): one fail() exit for caught update-flow errors
  
  sunnylqm
  and
  claude
  committed
  624ef5e
- fix(android): stop retrying mirrors after PATCH_FAILED in the native round
  
  sunnylqm
  and
  claude
  committed
  0107360
- fix(android): keep https-configured native rounds off plaintext
  
  sunnylqm
  and
  claude
  committed
  a989041
- refactor(client): simplify performDownload bookkeeping
  
  sunnylqm
  and
  claude
  committed
  f01140f
- refactor(harmony): share the NAPI async-work plumbing in pushy.cpp
  
  sunnylqm
  and
  claude
  committed
  78e1318
- refactor(harmony): single X-macro method table in PushyTurboModule.cpp
  
  sunnylqm
  and
  claude
  committed
  452b1ee
- chore(test): share the cpp test scripts' SANITIZE/FUZZ plumbing
  
  sunnylqm
  and
  claude
  committed
  cd08464
- refactor(provider): dedupe catch blocks and context actions
  
  sunnylqm
  and
  claude
  committed
  5e1ca68
- chore(packlist): derive the whitelist from package.json files
  
  sunnylqm
  and
  claude
  committed
  6117a35
- refactor(harmony): dedupe DownloadTask file helpers
  
  sunnylqm
  and
  claude
  committed
  2b7f243
- refactor(harmony): trim UpdateContext wrappers and the getAllSync probe
  
  sunnylqm
  and
  claude
  committed
  4a233f4
- chore: remove dead JS exports and locale keys
  
  sunnylqm
  and
  claude
  committed
  3909fee
- chore(flow-core): drop the unused uuid input of buildCheckFingerprint
  
  sunnylqm
  and
  claude
  committed
  2492ab8
- refactor(harmony): dedupe SyncCoordinator query and commit paths
  
  sunnylqm
  and
  claude
  committed
  bfe9342
- refactor(harmony): one Logger.log for all levels; log constants minus uuid
  
  sunnylqm
  and
  claude
  committed
  b527d16
- refactor(harmony): share the install record predicate
  
  sunnylqm
  and
  claude
  committed
  e66970a
- refactor(harmony): call applicationContext.restartApp directly
  
  sunnylqm
  and
  claude
  committed
  fb03dbf
- refactor(android): one UpdateModule for both architectures
  
  sunnylqm
  and
  claude
  committed
  7555ee0
- refactor(harmony): require hvigor task registration in the build-meta plugin
  
  sunnylqm
  and
  claude
  committed
  b005fc2
- ci(e2e): share the e2e setup between Android and iOS, dedupe config
  
  sunnylqm
  and
  claude
  committed
  fc27327
- ci(publish): move the shared publish steps into a composite action
  
  sunnylqm
  and
  claude
  committed
  21d07ea
- chore(scripts): drop the stale debug e2e npm scripts
  
  sunnylqm
  and
  claude
  committed
  2879337
- refactor(android): lambdas and one thread helper
  
  sunnylqm
  and
  claude
  committed
  c198d72
- build(harmony): compile shared native sources in place, drop the staging copy
  
  sunnylqm
  and
  claude
  committed
  4c96721
- refactor(android): share install presence and activation checks
  
  sunnylqm
  and
  claude
  committed
  22af75b
- refactor(android): tidy UpdateContext state ops, downloads and cleanup
  
  sunnylqm
  and
  claude
  committed
  b6e4c41
- build(harmony): move the CI SDK discovery into check-harmony-types.js
  
  sunnylqm
  and
  claude
  committed
  e66688a
- ci(harmony): dedupe trigger paths and drop checks bun lint already runs
  
  sunnylqm
  and
  claude
  committed
  373a7d0
- refactor(android): share the patch-task prelude in DownloadTask
  
  sunnylqm
  and
  claude
  committed
  7eef0bb
- docs: condense the native-check followups and bundleHash migration
  
  sunnylqm
  and
  claude
  committed
  3c0871f
- test: one loader for native sources and Harmony VM modules
  
  sunnylqm
  and
  claude
  committed
  b32291a
- test: shared client test helpers, real client in provider render tests
  
  sunnylqm
  and
  claude
  committed
  725c3d5
- style(client): keep UpdateErrorListener's doc comment on its type
  
  sunnylqm
  and
  claude
  committed
  63b2c0c
- refactor(android): one set of IO and HTTP helpers
  
  sunnylqm
  and
  claude
  committed
  a9e9242
- ci(lint): mention the constant parity check in the lint step comment
  
  sunnylqm
  and
  claude
  committed
  3ed50e3
- style: biome-format the harmony sync tests
  
  sunnylqm
  and
  claude
  committed
  92186a3
- test(harmony): run the pure-logic tests under bun, drop the hypium suite
  
  sunnylqm
  and
  claude
  committed
  8080818
- refactor(android): one endpoint attempt path in SyncCoordinator
  
  sunnylqm
  and
  claude
  committed
  620f600
- refactor(android): one entry map in BundledResourceCopier
  
  sunnylqm
  and
  claude
  committed
  fa7dfac
- refactor(android): small cleanups across the module
  
  sunnylqm
  and
  claude
  committed
  02ba2b5
- docs(audit): compress fixed CODE_AUDIT items, keep the open ones in full
  
  sunnylqm
  and
  claude
  committed
  d6b2201
- build(android): drop two proguard rules nothing needs any more
  
  sunnylqm
  and
  claude
  committed
  2b78967
- refactor(ios): Foundation-only common header for shared internals
  
  sunnylqm
  and
  claude
  committed
  d4c78a6
- fix(ios): align the native round's download and config rules with JS/Harmony
  
  sunnylqm
  and
  claude
  committed
  b5f572a
- Merge branch 'cleanup/core-ci' into claude/code-cleanup-refactor-dd7306
  sunnylqm
  committed
  df20ff2
- Merge branch 'cleanup/js' into claude/code-cleanup-refactor-dd7306
  sunnylqm
  committed
  9f7a8c3
- Merge branch 'cleanup/harmony' into claude/code-cleanup-refactor-dd7306
  sunnylqm
  committed
  f4b9b39
- test(harmony): load Harmony sources through the shared evalHarmonyModule
  
  sunnylqm
  and
  claude
  committed
  ed9d28b
- test(text-encoding): drop stale PushyTurboModule.cpp allowlist entries
  
  sunnylqm
  and
  claude
  committed
  dd6618f
- test(harmony): drop the stale hypium suite mention from harmonyInstallRecord
  
  sunnylqm
  and
  claude
  committed
  3adcffb
- docs(harmony): point comments at scripts/check-constant-parity.js, drop hypium mentions
  
  sunnylqm
  and
  claude
  committed
  d5791c2
- chore(package): drop the files exclusion for the removed harmony/pushy/src/test
  
  sunnylqm
  and
  claude
  committed
  d0a4409
- chore(e2e): remove the one-off iOS crash-rescue experiment scaffolding
  
  sunnylqm
  and
  claude
  committed
  97a4e8b
- refactor(ios): split RCTPushy.mm by responsibility, RCTPushyInstaller
  
  sunnylqm
  and
  claude
  committed
  fb234a8
- chore(podspec): drop dead fallbacks and search paths
  
  sunnylqm
  and
  claude
  committed
  457d65e
- fix(client): release applyingUpdate before emitting a beforeReload hook error
  
  sunnylqm
  and
  claude
  committed
  3376124
- fix(core): let a synchronous getBundleHash throw fail the module load again
  
  sunnylqm
  and
  claude
  committed
  cae4f9d
- refactor(harmony): build patch manifests with the shared delta::BuildPatchManifest
  
  sunnylqm
  and
  claude
  committed
  1707311
- Merge branch 'cleanup/android' into claude/code-cleanup-refactor-dd7306
  sunnylqm
  committed
  8f5b301
- chore(parity): check the merged Android UpdateModule and the oldarch NativePushySpec
  
  sunnylqm
  and
  claude
  committed
  a122c32
- Merge branch 'cleanup/ios' into claude/code-cleanup-refactor-dd7306
  sunnylqm
  committed
  26565ef
- fix(ios): include hpatch.h by relative path so use_frameworks! builds resolve it
  
  sunnylqm
  and
  claude
  committed
  e30cedf
- refactor(android): move the JNI glue out of the shared cores into cpp/android_jni
  
  sunnylqm
  and
  claude
  committed
  5a5b8e1
- refactor(android): fold patch_core_android.cpp into update_core_android.cpp
  
  sunnylqm
  and
  claude
  committed
  2225eba
- refactor(cpp): move the hpatch wrapper from android/jni to cpp/hpatch
  
  sunnylqm
  and
  claude
  committed
  e1b039f
- build: pick the shared C++ sources by directory on every platform
  
  sunnylqm
  and
  claude
  committed
  6968b12
- chore(package): ship cpp/ as a whole and scan it in the native source tests
  
  sunnylqm
  and
  claude
  committed
  9d7fd82
- feat(flow-core): shared native config gate, equivalence and normalizer
  
  sunnylqm
  and
  claude
  committed
  761d40d
- refactor(android): use the shared config gate, equivalence and normalizer
  
  sunnylqm
  and
  claude
  committed
  f4b78e1
- refactor(ios): use the shared config gate, equivalence and normalizer
  
  sunnylqm
  and
  claude
  committed
  1d95ca4
- refactor(harmony): use the shared config gate, equivalence and normalizer
  
  sunnylqm
  and
  claude
  committed
  6a606a3
- feat(flow-core): caller-chosen parse limits and linear object parsing
  
  sunnylqm
  and
  claude
  committed
  2459388
- feat(patch-core): one __diff.json parser and an ApplyArchivePatch entry point
  
  sunnylqm
  and
  claude
  committed
  52b7d84
- refactor(android): hand __diff.json to the shared core as bytes
  
  sunnylqm
  and
  claude
  committed
  02e383d
- refactor(ios): hand __diff.json to the shared core as text
  
  sunnylqm
  and
  claude
  committed
  20acb8e
- refactor(harmony): hand __diff.json to the shared core as text
  
  sunnylqm
  and
  claude
  committed
  4fc51ca
- refactor(patch-core): drop BuildPatchManifest
  
  sunnylqm
  and
  claude
  committed
  c4ba7ac
- feat(patch-core): one completion record implementation in install_record.cpp
  
  sunnylqm
  and
  claude
  committed
  555ffee
- refactor(android): use the shared completion record core
  
  sunnylqm
  and
  claude
  committed
  8966c5e
- refactor(patch-core): define Status::Ok/Error inline
  
  sunnylqm
  and
  claude
  committed
  bde5b2f
- refactor(ios): use the shared completion record core
  
  sunnylqm
  and
  claude
  committed
  6a7e52e
- test(ios-purge-restore): drop the stale PushyFileStamp note
  
  sunnylqm
  and
  claude
  committed
  7a96ce5
- refactor(harmony): use the shared completion record core
  
  sunnylqm
  and
  claude
  committed
  46d6d86
- feat(flow-core): one native round core for request, query walk and response
  
  sunnylqm
  and
  claude
  committed
  e13bc05
- refactor(android): run the cold-start round through the shared round core
  
  sunnylqm
  and
  claude
  committed
  1138e36
- refactor(ios): run the cold-start round through the shared round core
  
  sunnylqm
  and
  claude
  committed
  c90ac4c
- refactor(harmony): run the cold-start round through the shared round core
  
  sunnylqm
  and
  claude
  committed
  e80703f
- docs(audit): the https-only filter and round helpers live in the shared core
  
  sunnylqm
  and
  claude
  committed
  a4e65b6
- feat(patch-core): one archive extraction accounting in archive_limits.cpp
  
  sunnylqm
  and
  claude
  committed
  07717fe
- refactor(ios): run the unzip guard and the download probe through archive_limits
  
  sunnylqm
  and
  claude
  committed
  5fe601c
- refactor(android): run the archive accounting through archive_limits over JNI
  
  sunnylqm
  and
  claude
  committed
  1c47311
- refactor(harmony): run the archive checks through archive_limits over NAPI
  
  sunnylqm
  and
  claude
  committed
  65ec36c
- docs(audit): the archive limit accounting lives in the shared core
  
  sunnylqm
  and
  claude
  committed
  629b641
- build(android): rebuild librnpushy.so for the shared-core JNI surface
  
  sunnylqm
  and
  claude
  committed
  6eac197
- fix: address self-review findings on the shared-core round
  
  sunnylqm
  and
  claude
  committed
  163c999
- test(e2e): let the previous launch's native round settle before flipping forceBoot
  
  sunnylqm
  and
  claude
  committed
  c8c77f7
- test(e2e): give the local-merge install hook its own 10min budget
  
  sunnylqm
  and
  claude
  committed
  9f35e68

Commits

Commits on Oct 12, 2026