Skip to content

Handle autoCapitalize for native <TextInput /> #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wlabu wants to merge 12 commits into from
Closed

Handle autoCapitalize for native <TextInput /> #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
89fe922
red tests for <TextInput autoCapitalize />
wlabu Dec 10, 2025
0a2c97e
align types for global autoCapitalize prop
wlabu Dec 10, 2025
8f203c5
map autoCapitalize to values in createStrictDOMTextInputComponent
wlabu Dec 10, 2025
eda6c0e
update snapshots for 'global' input & textarea
wlabu Dec 10, 2025
b0ab666
fix tests after rebase
wlabu Dec 12, 2025
612f80d
fix web test & snaps for autoCapitalize
wlabu Dec 12, 2025
b30428a
remove 'case true' for native handler
wlabu Dec 12, 2025
c903919
align types (remove on & off)
wlabu Dec 12, 2025
9f493a3
use 'sentences' in web tests
wlabu Dec 12, 2025
a1d6cd5
remove on & off in native tests
wlabu Dec 12, 2025
16020fb
clean up autoCapitalize native implementation
wlabu Dec 12, 2025
90b7e8b
nit: alphabetise prop order
wlabu Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-strict-dom/src/native/modules/createStrictDOMTextInputComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ export function createStrictDOMTextInputComponent<P: StrictInputProps, T>(
const elementRef = useStrictDOMElement<T>(ref, { tagName });

const {
autoCapitalize,
autoComplete,
defaultValue,
disabled,
Expand Down Expand Up @@ -121,6 +122,9 @@ export function createStrictDOMTextInputComponent<P: StrictInputProps, T>(

// Component-specific props

if (autoCapitalize != null) {
nativeProps.autoCapitalize = autoCapitalize;
}
if (autoComplete != null) {
nativeProps.autoComplete = autoComplete;
}
Expand Down
9 changes: 1 addition & 8 deletions packages/react-strict-dom/src/types/StrictReactDOMProps.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,14 +280,7 @@ export type StrictReactDOMProps = $ReadOnly<{
onTouchMove?: $FlowFixMe, // TEMP

// Other
autoCapitalize?: ?(
| 'off'
| 'none'
| 'on'
| 'sentences'
| 'words'
| 'characters'
),
autoCapitalize?: ?('none' | 'sentences' | 'words' | 'characters'),
autoFocus?: ?boolean,
children?: React.Node,
'data-layoutconformance'?: ?('classic' | 'strict'),
Expand Down
1 change: 1 addition & 0 deletions packages/react-strict-dom/src/types/renderer.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ type ReactNativeProps = {
text?: ?string
},
accessibilityViewIsModal?: ?boolean,
autoCapitalize?: ?('none' | 'sentences' | 'words' | 'characters'),
autoComplete?: ?string,
alt?: ?Stringish,
animated?: ?boolean, // non-standard
Expand Down
2 changes: 2 additions & 0 deletions packages/react-strict-dom/tests/html/__snapshots__/html-test.js.snap-native
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3204,6 +3204,7 @@ exports[`<html.*> "input" supports global attributes 1`] = `
}
}
accessibilityViewIsModal={true}
autoCapitalize="sentences"
enterKeyHint="go"
focusable={true}
importantForAccessibility="no-hide-descendants"
Expand Down Expand Up @@ -5491,6 +5492,7 @@ exports[`<html.*> "textarea" supports global attributes 1`] = `
}
}
accessibilityViewIsModal={true}
autoCapitalize="sentences"
enterKeyHint="go"
focusable={true}
importantForAccessibility="no-hide-descendants"
Expand Down
Loading