Skip to content

Fix props for <select> and <option> elements#336

Merged
necolas merged 1 commit into
mainfrom
fix/select-and-option-props
Jul 11, 2025
Merged

Fix props for <select> and <option> elements#336
necolas merged 1 commit into
mainfrom
fix/select-and-option-props

Conversation

@necolas

@necolas necolas commented Jul 11, 2025

Copy link
Copy Markdown
Contributor

Unlike in HTML, passing a selected attribute to <option> is not supported. Instead, the selected option's value should be passed to thevalue or defaultValue props of the <select> element.

Fix #335

Unlike in HTML, passing a `selected` attribute to `<option>` is not
supported. Instead, the selected option's value should be passed to
the`value` or `defaultValue` props of the `<select>` element.

Fix #335
@github-actions

Copy link
Copy Markdown

workflow: benchmarks/size

Comparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.

Results Base Patch Ratio
react-strict-dom/dist/dom/index.js
· compressed 2,514 2,514 1.00
· minified 8,691 8,691 1.00
react-strict-dom/dist/dom/runtime.js
· compressed 855 855 1.00
· minified 2,435 2,435 1.00
react-strict-dom/dist/native/index.js
· compressed 16,065 16,065 1.00
· minified 59,912 59,912 1.00

@github-actions

Copy link
Copy Markdown

workflow: benchmarks/perf (native)

Comparison of performance test results, measured in operations per second. Larger is better.

Results Base Patch Ratio
css.create
· small 1,126,037 1,137,111 1.01 +
· small with units 428,690 431,880 1.01 +
· small with variables 650,477 661,695 1.02 +
· several small 316,201 321,480 1.02 +
· large 201,171 208,019 1.03 +
· large with polyfills 141,669 146,100 1.03 +
· complex 97,014 98,863 1.02 +
· unsupported 212,362 217,219 1.02 +
css.createTheme
· simple theme 227,427 227,410 1.00 -
· polyfill theme 212,633 212,193 1.00 -
css.props
· small 275,373 274,305 1.00 -
· small with units 221,730 221,254 1.00 -
· small with variables 112,258 112,992 1.01 +
· small with variables of units 78,863 78,953 1.00 +
· large 118,625 117,369 0.99 -
· large with polyfills 41,586 41,736 1.00 +
· complex 25,482 25,483 1.00 +
· unsupported 172,998 176,162 1.02 +
· simple merge 185,943 185,270 1.00 -
· wide merge 19,420 19,337 1.00 -
· deep merge 19,187 18,924 0.99 -
· themed merge 36,727 36,720 1.00 -

@MoOx MoOx left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@necolas necolas merged commit 901baba into main Jul 11, 2025
8 checks passed
@necolas necolas deleted the fix/select-and-option-props branch July 25, 2025 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

html.select is missing typescript types for value/defaultValue

3 participants