Add a batched scheduler delegate call for animated prop updates - #58764
Closed
bartlomiejbloniarz wants to merge 2 commits into
Closed
bartlomiejbloniarz wants to merge 2 commits into
bartlomiejbloniarz wants to merge 2 commits into
Conversation
Summary: The animation backend hands its synchronous updates to the platform one view at a time. This adds `UIManager::synchronouslyUpdateAnimatedProps` and a matching `SchedulerDelegate` call that receive a whole frame's updates at once, continuing #56771. The backend uses it when `optimizedAnimatedPropUpdates` is on. The default delegate implementation forwards to the existing per-view update, so platforms that don't implement it are unaffected. Changelog: [General][Changed] - Add a batched scheduler delegate call for animated prop updates behind `optimizedAnimatedPropUpdates` Test Plan: - New `SchedulerDelegateTest.animatedPropsUseExistingViewUpdatesByDefault` passes, covering raw and typed props. - The Android arm64 release build of the whole stack succeeds. - C++ API snapshots regenerated. Not built for iOS.
…s and scaffolding Tests and C++ API snapshots for the change in the parent commit.
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
bartlomiejbloniarz
added this pull request to stack #58767
September 30, 2026 13:00
|
Caution Invalid Base Branch The base branch for this PR is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
The animation backend hands its synchronous updates to the platform one view at a time. This adds
UIManager::synchronouslyUpdateAnimatedPropsand a matchingSchedulerDelegatecall that receive a whole frame's updates at once, continuing #56771. The backend uses it whenoptimizedAnimatedPropUpdatesis on. The default delegate implementation forwards to the existing per-view update, so platforms that don't implement it are unaffected.Changelog:
[General] [Changed] - Add a batched scheduler delegate call for animated prop updates behind
optimizedAnimatedPropUpdatesTest Plan:
SchedulerDelegateTest.animatedPropsUseExistingViewUpdatesByDefaultpasses, covering raw and typed props.