Close the Android dev menu when the menu key is pressed again - #58668
Closed
alanjhughes wants to merge 1 commit into
Closed
alanjhughes wants to merge 1 commit into
alanjhughes wants to merge 1 commit into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Expo
|
@shwanton has imported this pull request. If you are a Meta employee, you can view this in D121616477. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
On Android, the menu key (
Cmd+M) opens the dev menu, but a second press does not close it. On iOS,Cmd+Dtoggles the dev menu. This PR makes Android work the same way.Changelog:
[ANDROID] [FIXED] - Pressing the menu key while the dev menu is open now closes it
Test Plan:
RNTester on an emulator. Toggling works as expected